Skip to content

Commit

Permalink
CLDR-17572 Move LR marker div below star
Browse files Browse the repository at this point in the history
-Move the LR marker div below the i-star icon, simply by moving the call to checkLRmarker a few lines lower

-Also remove a comment in the same file about appendExample which is no longer true, and remove the export for appendExample which is no longer needed
  • Loading branch information
btangmu committed Aug 23, 2024
1 parent 67afecd commit e7dba78
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions tools/cldr-apps/js/src/esm/cldrTable.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -1031,16 +1031,14 @@ function addVitem(td, tr, theRow, item, newButton) {
subSpan.className = "subSpan";
cldrVote.appendItem(subSpan, displayValue, item.pClass);
choiceField.appendChild(subSpan);

checkLRmarker(choiceField, item.value);

if (item.isBaselineValue == true) {
cldrDom.appendIcon(
choiceField,
"i-star",
cldrText.get("voteInfo_baseline_desc")
);
}
checkLRmarker(choiceField, item.value);
if (item.votes && !isWinner) {
if (
item.valueHash == theRow.voteVhash &&
Expand Down Expand Up @@ -1185,7 +1183,6 @@ function appendExampleIcon(parent, text, loc) {
return el;
}

// caution: this is called from other modules as well as by appendExampleIcon
function appendExample(parent, text, loc) {
const el = document.createElement("div");
el.className = "d-example well well-sm";
Expand Down Expand Up @@ -1429,7 +1426,6 @@ function resetLastShown() {
export {
NO_WINNING_VALUE,
EMPTY_ELEMENT_VALUE,
appendExample,
getPageUrl,
getRowApprovalStatusClass,
getStatusIcon,
Expand Down

0 comments on commit e7dba78

Please sign in to comment.