CLDR-17140 kbd: modifiers review comments

unicode-org · Oct 11, 2023 · 6870355 · 6870355
1 parent 3978e26
commit 6870355
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/docs/ldml/tr35-keyboards.md b/docs/ldml/tr35-keyboards.md
@@ -1378,7 +1378,7 @@ _Attribute:_ `modifiers` (required for `hardware`)
 
 > This has two roles. It acts as an identifier for the `layer` element for hardware keyboards (in the absence of the id= element) and also provides the linkage from the hardware modifiers into the correct `layer`.
 >
-> For hardware layouts, the use of `@modifiers` as an identifier for a layer is sufficient since it is always unique among the set of `layer` elements in a keyboard.
+> For hardware layouts, the use of `@modifiers` as an identifier for a layer is sufficient since it is always unique among the set of `layer` elements in each  `form`.
 >
 > The set of modifiers must match `(none|([A-Za-z0-9]+)( [A-Za-z0-9]+)*)`
 >

diff --git a/...r-code/src/test/resources/org/unicode/cldr/tool/KeyboardFlatten/broken-import-missing.xml b/...r-code/src/test/resources/org/unicode/cldr/tool/KeyboardFlatten/broken-import-missing.xml
@@ -69,7 +69,7 @@
             <row keys="space" />
         </layer>
 
-        <layer modifiers="altR-shift">
+        <layer modifiers="altR shift">
             <row keys="not gap gap gap gap gap gap gap gap gap gap gap gap" />
             <row keys="gap gap E-grave gap gap gap U-grave I-grave O-grave gap open-curly close-curly" />
             <row keys="A-grave gap gap gap gap gap gap gap gap gap gap gap" />

diff --git a/...de/src/test/resources/org/unicode/cldr/tool/KeyboardFlatten/broken-import-unknownbase.xml b/...de/src/test/resources/org/unicode/cldr/tool/KeyboardFlatten/broken-import-unknownbase.xml
@@ -69,7 +69,7 @@
             <row keys="space" />
         </layer>
 
-        <layer modifiers="altR-shift">
+        <layer modifiers="altR shift">
             <row keys="not gap gap gap gap gap gap gap gap gap gap gap gap" />
             <row keys="gap gap E-grave gap gap gap U-grave I-grave O-grave gap open-curly close-curly" />
             <row keys="A-grave gap gap gap gap gap gap gap gap gap gap gap" />

diff --git a/...ode/src/test/resources/org/unicode/cldr/tool/KeyboardFlatten/broken-import-unknownver.xml b/...ode/src/test/resources/org/unicode/cldr/tool/KeyboardFlatten/broken-import-unknownver.xml
@@ -71,7 +71,7 @@
             <row keys="space" />
         </layer>
 
-        <layer modifiers="altR-shift">
+        <layer modifiers="altR shift">
             <row keys="not gap gap gap gap gap gap gap gap gap gap gap gap" />
             <row keys="gap gap E-grave gap gap gap U-grave I-grave O-grave gap open-curly close-curly" />
             <row keys="A-grave gap gap gap gap gap gap gap gap gap gap gap" />

diff --git a/...de/src/test/resources/org/unicode/cldr/tool/KeyboardFlatten/broken-import-wrongparent.xml b/...de/src/test/resources/org/unicode/cldr/tool/KeyboardFlatten/broken-import-wrongparent.xml
@@ -69,7 +69,7 @@
             <row keys="space" />
         </layer>
 
-        <layer modifiers="altR-shift">
+        <layer modifiers="altR shift">
             <row keys="not gap gap gap gap gap gap gap gap gap gap gap gap" />
             <row keys="gap gap E-grave gap gap gap U-grave I-grave O-grave gap open-curly close-curly" />
             <row keys="A-grave gap gap gap gap gap gap gap gap gap gap gap" />