Skip to content

Commit

Permalink
CLDR-17388 update known issues
Browse files Browse the repository at this point in the history
- remove additional commented-out or now-passing issues
  • Loading branch information
srl295 committed Feb 24, 2024
1 parent 1550f0f commit 4defbc2
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 30 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -308,10 +308,6 @@ void show(boolean verbose, ImmutableSet<ValueStatus> retain) {
testLog.warnln("Skipping for keyboard3");

Check warning on line 308 in tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestAttributeValues.java

View workflow job for this annotation

GitHub Actions / build

(TestAttributeValues.java:308) Warning: Skipping for keyboard3
}
boolean haveProblems = false;
// if (testLog.logKnownIssue("cldrbug 10120", "Don't enable error until
// complete")) {
// testLog.warnln("Counts: " + counter.toString());
// } else
for (ValueStatus valueStatus : ValueStatus.values()) {
if (valueStatus == ValueStatus.valid) {
continue;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -795,12 +795,6 @@ public void TestFileIds() {
}
String likely = likelySubtags.minimize(loc);
if (!localesToDirs.containsKey(parent)) {
// if (ldmlDir == LdmlDir.rbnf && source == Source.common &&
// parent.equals("en_001") && loc.equals("en_IN") &&
// logKnownIssue("cldrbug:10456", "Missing parent
// (en_001) for en_IN in common/rbnf")) {
// continue;
// }
errln(
"Missing parent ("
+ parent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -947,9 +947,7 @@ public void TestTimeData() {
+ oldSchool
+ " in allowed: "
+ preferredAndAllowedHour.allowed;
// if (!logKnownIssue("cldrbug:11448", message)) {
errln(message);
// }
}
break;
}
Expand Down Expand Up @@ -1876,13 +1874,6 @@ public void TestPluralCompleteness() {
testLocales.contains(locale) ? CoverageIssue.error : CoverageIssue.log;
CoverageIssue needsCoverage2 =
needsCoverage == CoverageIssue.error ? CoverageIssue.warn : needsCoverage;

// if (logKnownIssue("Cldrbug:8809", "Missing plural rules/samples be and ga
// locales")) {
// if (locale.equals("be") || locale.equals("ga")) {
// needsCoverage = CoverageIssue.warn;
// }
// }
PluralRulesFactory prf =
PluralRulesFactory.getInstance(
CLDRConfig.getInstance().getSupplementalDataInfo());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -672,13 +672,6 @@ public void TestCasing() {

String lithuanianSource =
"I \u00CF J J\u0308 \u012E \u012E\u0308 \u00CC \u00CD \u0128 xi\u0307\u0308 xj\u0307\u0308 x\u012F\u0307\u0308 xi\u0307\u0300 xi\u0307\u0301 xi\u0307\u0303 XI X\u00CF XJ XJ\u0308 X\u012E X\u012E\u0308";
// The following test was formerly skipped with
// !logKnownIssue("11094", "Fix ICU4J UCharacter.toTitleCase/toLowerCase for lt").
// However [https://unicode-org.atlassian.net/browse/ICU-11094] is supposedly
// fixed in the version of ICU4J currently in CLDR, but removing the logKnownIssue
// to execute the test results in test failures, mainly for i\u0307\u0308.
// So I am changing the logKnownIssue to reference a CLDR ticket about
// investigating the test (it may be wrong).
if (!logKnownIssue(
"cldrbug:13313", "Investigate the Lithuanian casing test, it may be wrong")) {
Transliterator ltTitle =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,6 @@ public void TestCompatibility() {
if (ALLOWED_MISSING.contains(code)) {
continue;
}
if (code.equals("cqzzzz")
&& logKnownIssue("CLDR-16464", "Skipping cqzzzz")) {
continue;
}
errln(
messages,
type
Expand Down

0 comments on commit 4defbc2

Please sign in to comment.