CLDR-17756 Either skip failures or logKnown Issues

unicode-org · Jul 11, 2024 · 2387814 · 2387814
1 parent dc5c4c0
commit 2387814
Show file tree

Hide file tree

Showing 2 changed files with 326 additions and 33 deletions.
diff --git a/tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestCheckCLDR.java b/tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestCheckCLDR.java
@@ -1089,7 +1089,7 @@ public void TestShowRowAction() {
 
         for (String locale : localesForRowAction) {
             DummyPathValueInfo dummyPathValueInfo = new DummyPathValueInfo();
-            dummyPathValueInfo.locale = CLDRLocale.getInstance(locale);
+            dummyPathValueInfo.setLocale(CLDRLocale.getInstance(locale));
             CLDRFile cldrFile = testInfo.getCldrFactory().make(locale, true);
             CLDRFile cldrFileUnresolved = testInfo.getCldrFactory().make(locale, false);
 
@@ -1107,8 +1107,9 @@ public void TestShowRowAction() {
                     for (PathHeader ph : sorted) {
                         String path = ph.getOriginalPath();
                         SurveyToolStatus surveyToolStatus = ph.getSurveyToolStatus();
-                        dummyPathValueInfo.xpath = path;
-                        dummyPathValueInfo.baselineValue = cldrFileUnresolved.getStringValue(path);
+                        dummyPathValueInfo.setXpath(path);
+                        dummyPathValueInfo.setBaselineValue(
+                                cldrFileUnresolved.getStringValue(path));
                         StatusAction action =
                                 phase.getShowRowAction(
                                         dummyPathValueInfo, InputMethod.DIRECT, ph, dummyUserInfo);
@@ -1126,7 +1127,7 @@ public void TestShowRowAction() {
                                         "vo ==> FORBID_READONLY",
                                         StatusAction.FORBID_READONLY,
                                         action);
-                            } else if (dummyPathValueInfo.baselineValue == null) {
+                            } else if (dummyPathValueInfo.getBaselineValue() == null) {
                                 if (!assertEquals(
                                         "missing ==> ALLOW", StatusAction.ALLOW, action)) {
                                     warnln("\t\t" + locale + "\t" + ph);
@@ -1150,7 +1151,9 @@ public void TestShowRowAction() {
                                 }
                                 actionToExamplePath.put(
                                         key,
-                                        Pair.of(dummyPathValueInfo.baselineValue != null, path));
+                                        Pair.of(
+                                                dummyPathValueInfo.getBaselineValue() != null,
+                                                path));
                             }
                         }
                     }
@@ -1210,7 +1213,7 @@ public VoterInfo getVoterInfo() {
                 }
             };
 
-    private static class DummyPathValueInfo implements PathValueInfo {
+    public static class DummyPathValueInfo implements PathValueInfo {
         private CLDRLocale locale;
         private String xpath;
         private String baselineValue;
@@ -1271,6 +1274,18 @@ public CLDRLocale getLocale() {
         public String getXpath() {
             return xpath;
         }
+
+        public void setLocale(CLDRLocale locale) {
+            this.locale = locale;
+        }
+
+        public void setXpath(String xpath) {
+            this.xpath = xpath;
+        }
+
+        public void setBaselineValue(String baselineValue) {
+            this.baselineValue = baselineValue;
+        }
     }
 
     final Set<String> cldrLocales =