CLDR-17857 add a whole-locale warning for missing English name.

- warning, not error, otherwise we'd block builds! - new subtype missingEnglishName
unicode-org · Jul 31, 2024 · 1516aa2 · 1516aa2
1 parent 951ebdf
commit 1516aa2
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/tools/cldr-code/src/main/java/org/unicode/cldr/test/CheckCLDR.java b/tools/cldr-code/src/main/java/org/unicode/cldr/test/CheckCLDR.java
@@ -936,7 +936,8 @@ public enum Subtype {
             shortDateFieldInconsistentLength,
             illegalParameterValue,
             illegalAnnotationCode,
-            illegalCharacter;
+            illegalCharacter,
+            missingEnglishName;
 
             @Override
             public String toString() {

diff --git a/tools/cldr-code/src/main/java/org/unicode/cldr/test/CheckCoverage.java b/tools/cldr-code/src/main/java/org/unicode/cldr/test/CheckCoverage.java
@@ -10,6 +10,7 @@
 import org.unicode.cldr.test.CheckCLDR.CheckStatus.Subtype;
 import org.unicode.cldr.util.CLDRFile;
 import org.unicode.cldr.util.CLDRFile.Status;
+import org.unicode.cldr.util.CLDRLocale;
 import org.unicode.cldr.util.Factory;
 import org.unicode.cldr.util.InternalCldrException;
 import org.unicode.cldr.util.LanguageTagParser;
@@ -157,6 +158,25 @@ public CheckCLDR handleSetCldrFileToCheck(
         setSkipTest(false);
         latin = ValuePathStatus.isLatinScriptLocale(cldrFileToCheck);
 
+        // check whether the English name is present. See {@link
+        // LikelySubtagsTest#TestMissingInfoForLanguage}
+        {
+            final CLDRLocale locale = CLDRLocale.getInstance(localeID);
+            String path = CLDRFile.getKey(CLDRFile.LANGUAGE_NAME, locale.getLanguage());
+            // getEnglishFile() returns a resolved file, so just check isHere.
+            boolean englishName = getEnglishFile().isHere(path);
+            if (!englishName) {
+                possibleErrors.add(
+                        new CheckStatus()
+                                .setCause(this)
+                                .setMainType(CheckStatus.warningType)
+                                .setSubtype(Subtype.missingEnglishName)
+                                .setMessage(
+                                        "Missing English translation for " + locale.getLanguage(),
+                                        new Object[] {}));
+            }
+        }
+
         return this;
     }