CLDR-17316 cldr-apps-webdriver Java formatting with spotless #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Add toggleOffOn in pom.xml (the cldr project does not have that) -Add spotless:on and spotless:off comments in SurveyDriverData.java, replacing prettier-ignore -Other changes are only formatting results of running mvn spotless:apply
btangmu
commented
Jan 25, 2024
| @@ -58,6 +58,7 @@ | |||
| <ratchetFrom>NONE</ratchetFrom> | |||
| <!-- define a language-specific format --> | |||
| <java> | |||
| <toggleOffOn /> | |||
There was a problem hiding this comment.
@srl295 I'm a little surprised that cldr didn't need this, which enables spotless:on/off comments for disabling formatting of a few long arrays... probably those arrays should be implemented differently anyway but I think this is better than one item per line...
There was a problem hiding this comment.
CLDR probably needs this but didn't know about it. we just let spotless do what it wants to do. want to file an issue and/or put on the infra agenda?
There was a problem hiding this comment.
I'll put it on the agenda. I don't remember any specific instances of anyone being unhappy with the spotless results. I just vaguely recall such issues when various formatting options were being considered.
srl295
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Add toggleOffOn in pom.xml (the cldr project does not have that)
-Add spotless:on and spotless:off comments in SurveyDriverData.java, replacing prettier-ignore
-Other changes are only formatting results of running mvn spotless:apply