add/fix missing tests annotations, cleanup requirements.txt #639
Conversation
Scartography
commented
Jul 24, 2024
•
Scartography
commented
- minor fix and maintenance
- See CHANGELOG.rst and update TBD release day when ready
…nts.txt, update CHAGELOG and version
pyproject.toml
Outdated
| @@ -29,6 +29,7 @@ dependencies = [ | |||
| "distributed", | |||
| "fiona>=1.8.13.post1", | |||
| "fsspec", | |||
| "gdal>=3.6.4", | |||
There was a problem hiding this comment.
This should not be here because we don't import GDALs python bindings anywhere in the package. All GDAL related stuff is "hidden" within the builds of fiona and rasterio.
pyproject.toml
Outdated
| @@ -79,6 +80,7 @@ profiling = [ | |||
| ] | |||
| s3 = [ | |||
| "aiobotocore>=1.1.2", | |||
| "aioitertools>=0.7.0", | |||
There was a problem hiding this comment.
Same with aioitertools here. They are not a direct dependency of the package itself.
| @@ -1069,6 +1066,22 @@ def test_read_raster(path): | |||
| assert not rr.data.mask.all() | |||
|
|
|||
|
|
|||
| @pytest.mark.aws_s3 | |||
There was a problem hiding this comment.
aws_s3 is only for tests which access s3://mapchete-test testdata. These fixtures only use data from our docker based integration setup, so marking them with integration is sufficient.
There was a problem hiding this comment.
there is one raster_4bands_s3 so this somewhat applies only for 1 param there, and would probably not split this even further
requirements.txt
Outdated
| matplotlib>=3.2.1 | ||
| fsspec[http] | ||
| fsspec[s3] | ||
| gdal>=3.6.4 |
|
Agree with all the comments, will update the branch and also solve the |
…n pydantic, see if we can make this work
