Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning of deprecated argument (handle elegantly) #319

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

annahedstroem
Copy link
Member

Description

  • Added a warning for renamed metric argument

Minimum acceptance criteria

  • Specify what is necessary for the PR to be merged with the main branch.
  • @mentions of the person that is apt to review these changes e.g., @annahedstroem

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fcd8ded) 91.24% compared to head (d2d7f39) 91.20%.

❗ Current head d2d7f39 differs from pull request most recent head 6366f78. Consider uploading reports for the commit 6366f78 to get more accurate results

Files Patch % Lines
quantus/metrics/randomisation/mprt.py 50.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
- Coverage   91.24%   91.20%   -0.05%     
==========================================
  Files          66       66              
  Lines        3884     3887       +3     
==========================================
+ Hits         3544     3545       +1     
- Misses        340      342       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@annahedstroem annahedstroem merged commit 6430e69 into main Dec 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants