Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPRT metrics: EfficientMPRT and SmoothMPRT #308

Merged
merged 12 commits into from
Nov 24, 2023
Merged

MPRT metrics: EfficientMPRT and SmoothMPRT #308

merged 12 commits into from
Nov 24, 2023

Conversation

annahedstroem
Copy link
Member

@annahedstroem annahedstroem commented Nov 20, 2023

Description

Implemented changes

  • Insert a description of the changes implemented in the pull request.
    • Update model_parameter_randomisation.py
    • Write smooth_model_parameter_randomisation.py
    • Write efficient_model_parameter_randomisation.py
    • Tests for:
      • MPRT
      • eMPRT
      • sMPRT
  • Nb example

Also,

  • make some changes to ModelInterface w.r.t. channel_first default values

Minimum acceptance criteria

  • Specify what is necessary for the PR to be merged with the main branch.
  • @mentions of the person that is apt to review these changes e.g., @annahedstroem

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2023

Codecov Report

Attention: 60 lines in your changes are missing coverage. Please review.

Comparison is base (a12daa5) 0.00% compared to head (49954e9) 91.02%.

Files Patch % Lines
quantus/metrics/randomisation/smooth_mprt.py 86.93% 23 Missing ⚠️
quantus/metrics/randomisation/efficient_mprt.py 91.09% 17 Missing ⚠️
quantus/helpers/model/model_interface.py 47.05% 9 Missing ⚠️
quantus/metrics/randomisation/mprt.py 88.88% 6 Missing ⚠️
quantus/helpers/utils.py 76.92% 3 Missing ⚠️
quantus/evaluation.py 50.00% 1 Missing ⚠️
quantus/functions/complexity_func.py 95.65% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##           main     #308       +/-   ##
=========================================
+ Coverage      0   91.02%   +91.02%     
=========================================
  Files         0       66       +66     
  Lines         0     3876     +3876     
=========================================
+ Hits          0     3528     +3528     
- Misses        0      348      +348     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@annahedstroem annahedstroem changed the title Mprt metrics MPRTt metrics: EfficientMPRT and SmoothMPRT Nov 23, 2023
@annahedstroem annahedstroem changed the title MPRTt metrics: EfficientMPRT and SmoothMPRT MPRT metrics: EfficientMPRT and SmoothMPRT Nov 23, 2023
Copy link
Collaborator

@leanderweber leanderweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked through it. Seems good!

@annahedstroem
Copy link
Member Author

Notebook will be released at a later point.

@annahedstroem annahedstroem merged commit 327cecb into main Nov 24, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants