Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webusb and no verify xpub export #24

Merged
merged 16 commits into from
Jun 25, 2020
Merged

webusb and no verify xpub export #24

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
f3dae91
code styling, fix errors and typos
humanumbrella May 30, 2020
fdd68cf
eslint-disable `max-lines` in `eslintrc.json`
humanumbrella May 30, 2020
0b0fa67
include @ledgerhq/transport-webusb and disable verify:true on pubkey …
humanumbrella Jun 16, 2020
8d0cb47
bump hw-app-btc version
humanumbrella Jun 22, 2020
b3ea93e
code review feedback - not async function
humanumbrella Jun 22, 2020
ba79e8f
bump all ledger dependencies
humanumbrella Jun 22, 2020
61a755e
Explicitly remove U2F and code review
humanumbrella Jun 23, 2020
e516292
update package-lock.json
humanumbrella Jun 23, 2020
c3d7270
remove unnecessary async's
humanumbrella Jun 23, 2020
43e24bc
hw-app-btc version that includes `serializeTransactionOutputs`
humanumbrella Jun 23, 2020
f380389
bring hw-transport-u2f back for Firefox fallback option
humanumbrella Jun 24, 2020
1ff9a80
comment out messages in pubkey export tests for now
humanumbrella Jun 24, 2020
b6b4ead
comment out messages in xpub export
humanumbrella Jun 24, 2020
2449f11
images unused in this release
humanumbrella Jun 24, 2020
8cd4d6a
cleanup and remove commented code
humanumbrella Jun 24, 2020
7a5b6bd
remove commented code
humanumbrella Jun 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ledger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ import {
DirectKeystoreInteraction,
} from "./interaction";

import IMAGES from "./images";
//import IMAGES from "./images";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, we're not using the images at all anymore? I guess we don't use them or have them yet for signing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we were only showing images for xpubs/pubkeys at the moment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we were only showing images for xpubs/pubkeys at the moment

See also unchained-capital/caravan#112


/**
* Constant defining Ledger interactions.
Expand Down