Fix: Persistence layer creates zero-length initial shards file #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile - but it is zero-length
Codecov Report
@@ Coverage Diff @@
## master #32 +/- ##
=======================================
Coverage 57.83% 57.83%
=======================================
Files 25 25
Lines 1238 1238
Branches 168 168
=======================================
Hits 716 716
Misses 504 504
Partials 18 18
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into an issue when running hermit in several different environments (docker on Win10, docker on Ubuntu, Ubuntu, PyCharm on Ubuntu): hermit was not initializing the shards_file properly (with empty bson) and the UI was choking on it. Turns out that the persistence layer command was resulting in an empty initial file being created, and the existing code didn't catch it because it was only checking for the existence of the file.