Fix/unchained wallets integration

package.json

@@ -20,7 +20,11 @@
     "node": ">=20"
   },
   "overrides": {
-    "jspdf": "2.5.1"
+    "jspdf": "2.5.1",
+    "@ledgerhq/hw-transport-webusb": {
+      "@ledgerhq/hw-transport": "6.28.1",
+      "@ledgerhq/devices": "8.0.0"
+    }
   },
   "devDependencies": {
     "@babel/plugin-transform-runtime": "^7.21.0",
@@ -144,7 +148,7 @@
     "redux-thunk": "^2.3.0",
     "reselect": "^4.0.0",
     "sass": "^1.56.2",
-    "unchained-bitcoin": "^1.2.0",
+    "unchained-bitcoin": "^1.2.1",
     "unchained-wallets": "^1.0.3"
   }
 }

src/actions/transactionActions.js

@@ -276,10 +276,13 @@ export function setMaxSpendOnOutput(outputIndex) {
       new BigNumber(0)
     );
 
-    const spendAllAmount = satoshisToBitcoins(
-      new BigNumber(confirmedBalance)
-        .minus(outputs.length > 1 ? totalOutputValue : 0)
-        .minus(estimatedFee)
+    const spendAllAmount = new BigNumber(
+      satoshisToBitcoins(
+        new BigNumber(confirmedBalance)
+          .minus(outputs.length > 1 ? totalOutputValue : 0)
+          .minus(estimatedFee)
+          .toFixed(8)
+      )
     );
 
     if (
@@ -292,7 +295,7 @@ export function setMaxSpendOnOutput(outputIndex) {
           "Not enough available funds for max spend. Clear other outputs or wait for incoming deposits to confirm."
         )
       );
-    return dispatch(setOutputAmount(outputIndex, spendAllAmount));
+    return dispatch(setOutputAmount(outputIndex, spendAllAmount.toString()));
   };
 }
 

src/components/ScriptExplorer/SignatureImporter.jsx

@@ -631,16 +631,16 @@ function mapStateToProps(state, ownProps) {
     ...state.spend.transaction,
     requiredSigners: state.settings.requiredSigners,
     ledgerPolicyHmacs: state.wallet.common.ledgerPolicyHmacs,
-    extendedPublicKeys: Object.values(
-      state.quorum.extendedPublicKeyImporters
-    ).map((key) => ({
-      bip32Path: getMaskedDerivation({
+    extendedPublicKeys: Object.values(state.quorum.extendedPublicKeyImporters)
+      .filter((key) => key.extendedPublicKey)
+      .map((key) => ({
+        bip32Path: getMaskedDerivation({
+          xpub: key.extendedPublicKey,
+          bip32Path: key.bip32Path,
+        }),
+        xfp: key.rootXfp,
         xpub: key.extendedPublicKey,
-        bip32Path: key.bip32Path,
-      }),
-      xfp: key.rootXfp,
-      xpub: key.extendedPublicKey,
-    })),
+      })),
   };
 }
 

src/components/TestSuiteRun/TestRun.jsx

@@ -72,7 +72,7 @@ class TestRunBase extends React.Component {
     const { test } = this.props;
     const interaction = test.interaction();
     const nameBits = test.name().split(" ");
-    const body = interaction.request().data.toBase64();
+    const body = interaction.request();
     const timestamp = moment().format("HHmm");
     const filename = `${timestamp}-${nameBits[2]}-${nameBits[1][0]}.psbt`;
     downloadFile(body, filename);

src/tests/registration.jsx

@@ -19,6 +19,9 @@ class RegisterWalletPolicyTest extends Test {
   }
 
   description() {
+    const keyOrigins = this.params.braidDetails.extendedPublicKeys.sort(
+      (a, b) => a.base58String.localeCompare(b.base58String)
+    );
     return (
       <Box>
         <p>
@@ -47,7 +50,7 @@ class RegisterWalletPolicyTest extends Test {
                 Registering Quorum
               </TableCell>
             </TableRow>
-            {this.params.braidDetails.extendedPublicKeys.map((key, index) => (
+            {keyOrigins.map((key, index) => (
               <React.Fragment key={key.rootFingerprint}>
                 <TableRow>
                   <TableCell colSpan={6} style={{ textAlign: "center" }}>

src/utils/constants.js

@@ -1,8 +1,7 @@
-import BigNumber from "bignumber.js";
 import { satoshisToBitcoins } from "unchained-bitcoin";
 
 export const DUST_IN_SATOSHIS = 546;
-export const DUST_IN_BTC = satoshisToBitcoins(BigNumber(DUST_IN_SATOSHIS));
+export const DUST_IN_BTC = satoshisToBitcoins(DUST_IN_SATOSHIS.toString());
 export const DEFAULT_PREFIX = "m";
 export const CHANGE_INDEX = "/1";
 export const DEFAULT_CHANGE_PREFIX = DEFAULT_PREFIX + CHANGE_INDEX;

src/utils/index.js

@@ -1,5 +1,5 @@
 import BigNumber from "bignumber.js";
-import { estimateMultisigTransactionFee } from "unchained-bitcoin/lib/fees";
+import { estimateMultisigTransactionFee } from "unchained-bitcoin";
 
 import { DUST_IN_SATOSHIS } from "./constants";
 

vite.config.ts

@@ -24,4 +24,14 @@ export default defineConfig({
     __GIT_SHA__: JSON.stringify(process.env.__GIT_SHA__),
     __APP_VERSION__: JSON.stringify(process.env.npm_package_version),
   },
+  optimizeDeps: {
+    include: [
+      /*
+        Add packages you want to develop locally with caravan here
+        for example, uncomment the ones below if working on either package
+      */
+      // "unchained-bitcoin",
+      // "unchained-wallets",
+    ],
+  },
 });