Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly construct first and follow tables #21

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

Specy
Copy link
Collaborator

@Specy Specy commented Nov 17, 2024

(closes #20)

@Specy Specy requested a review from umut-sahin November 17, 2024 12:53
Copy link
Owner

@umut-sahin umut-sahin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also have some tests for correctly tracing/parsing with indirectly empty symbols? Just in case something else is buggy.

assets/grammars/correct/indirect_empty.lr Outdated Show resolved Hide resolved
src/tables.rs Outdated Show resolved Hide resolved
tests/parser.rs Outdated Show resolved Hide resolved
tests/parser.rs Outdated Show resolved Hide resolved
@umut-sahin umut-sahin changed the title fix: fixes bug for first table construction Correctly construct first and follow tables Nov 19, 2024
@umut-sahin umut-sahin merged commit 7bd9e90 into main Nov 19, 2024
7 checks passed
@umut-sahin umut-sahin deleted the fix/first-table branch November 19, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong first/follow?
2 participants