Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only use needed bevy features #5

Closed
wants to merge 2 commits into from

Conversation

TurtIeSocks
Copy link

@TurtIeSocks TurtIeSocks commented Oct 29, 2024

Thanks for the convenient utility library! This PR just disables Bevy's default features and specifies the only ones that are needed to run.

@umut-sahin
Copy link
Owner

Any idea why the CI is failing?

@TurtIeSocks
Copy link
Author

Apologies for the delay @umut-sahin. I had not ran the tests in a Linux env and it was missing the x11 feature. I've added it to the Cargo.toml and ran the build and test steps in WSL2 successfully.

@umut-sahin
Copy link
Owner

Could you fix CI issues?

Thanks for doing this BTW, I'll add you as an author before releasing the next version!

@umut-sahin
Copy link
Owner

umut-sahin commented Dec 5, 2024

I'll do this in #7 but I want to make you the author of the relevant commit. Could you share your e-mail for authors section:

authors = [
    "Umut Şahin <[email protected]>",
]

@umut-sahin
Copy link
Owner

Closing this as #7 is merged. @TurtIeSocks I'll add you as an author when you share your e-mail. Thanks!

@umut-sahin umut-sahin closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants