Skip to content
This repository has been archived by the owner on Aug 31, 2019. It is now read-only.

Center pagination controls #430

Closed
wants to merge 4 commits into from
Closed

Center pagination controls #430

wants to merge 4 commits into from

Conversation

mboneil10
Copy link
Contributor

Closes #419

@mboneil10
Copy link
Contributor Author

Still need to:

  • remove padding from pagination area
  • make the tappable area larger

@@ -35,5 +35,5 @@
</ion-checkbox>
</ion-item>
</ion-list>
<pagination-controls center class="pages" (pageChange)="p = $event"></pagination-controls>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk what this center is for... didn't seem to center the pagination

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, someone meant text-center (or this syntax has been deprecated, etc.). Now it "works".

@mboneil10
Copy link
Contributor Author

mboneil10 commented Sep 11, 2017

@akaplo, should I make a new scss file to remove padding and make a specific class for styling the pagination thing? I don't know what the best approach would be in terms of ionic. edit: yes, that's what is expected of the user. I can read again.

@mboneil10
Copy link
Contributor Author

I'll just do it anyway. That's what PRs are for!

@akaplo
Copy link

akaplo commented Sep 12, 2017

Go for it! You def don't need a new .scss file - we have one for each page plus a global one already, so you can just make your edits in the appropriate place.

@mboneil10
Copy link
Contributor Author

Thanks @akaplo

@mboneil10
Copy link
Contributor Author

mboneil10 commented Sep 24, 2017

Idk what's happening with this. I can't apply style in the way that the guide tells us to, and I've already tried every variation of using the different classes that pagination has. What I've done is put the "proper" syntax up here for anyone to look at. (Although I don't think that does much).

Should we still focus on getting the tappable area larger?

@mboneil10 mboneil10 requested a review from akaplo September 24, 2017 16:40
@akaplo
Copy link

akaplo commented Sep 24, 2017

This is a tough one indeed. I've played around with your changes, but also with no real luck. What you're doing seems correct to me.

@mboneil10
Copy link
Contributor Author

I'll close this since I couldn't figure it out. Maybe someone else will be able to.

@mboneil10 mboneil10 closed this Oct 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants