Skip to content
This repository has been archived by the owner on Aug 31, 2019. It is now read-only.

"Edit Favorite Stops": Pagination should be centered #419

Open
janpio opened this issue Aug 6, 2017 · 9 comments
Open

"Edit Favorite Stops": Pagination should be centered #419

janpio opened this issue Aug 6, 2017 · 9 comments

Comments

@janpio
Copy link
Contributor

janpio commented Aug 6, 2017

... instead of padding-lefted. Tappable area should probably also be a bit bigger.

@mboneil10
Copy link
Contributor

Is there an ionic/mobile app style guide you're referring to, @janpio?

@janpio
Copy link
Contributor Author

janpio commented Aug 16, 2017

No, this just looks odd non-centered. iPhone 5S looks quite different than a iPhone 6 Plus for example.

@mboneil10
Copy link
Contributor

Ah, okay. Thank you. I agree that the padding looks a bit odd and could be centered instead. As for the tappable area, it seems to be the same size as the stop checkboxes.

@akaplo
Copy link

akaplo commented Aug 16, 2017

@mboneil10 if you need help with this lmk. FYI we use a library for pagination. They have an option for us to override their styling entirely but keep their functionality (it works pretty well) - perhaps it's something we should consider.

@mboneil10
Copy link
Contributor

Okay, I can do that.

@mboneil10 mboneil10 self-assigned this Aug 17, 2017
@mboneil10
Copy link
Contributor

mboneil10 commented Aug 26, 2017

I'm hesitant on overriding styling. But since it's only a library I don't feel that bad about it.

@akaplo
Copy link

akaplo commented Aug 28, 2017

The library is built under the assumption that users will be overriding.

@mboneil10
Copy link
Contributor

Seems like we can't easily override the styling on this library. Issue is on standby.

@mboneil10 mboneil10 removed their assignment Oct 31, 2017
@mboneil10 mboneil10 self-assigned this Mar 15, 2018
@mboneil10
Copy link
Contributor

Maybe #457 will fix this.

@mboneil10 mboneil10 removed their assignment Nov 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants