Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xgettext path #6

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

xgettext path #6

wants to merge 6 commits into from

Conversation

oleksandr-diudiun
Copy link

For temporary work version I create constant for xgettext PATH in twig-gettext-extractor and add some actual comments

@umpirsky
Copy link
Owner

How about just adding setGettextCommand() to Twig/Gettext/Extractor.php. So, this class will have command attribute with default value set to xgettext?

This will allow users to have custom twig-gettext-extractor where they can set it.

@oleksandr-diudiun
Copy link
Author

ок, i will change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleksandr-diudiun @umpirsky