Code

Better CI#98

Code

Merged

brainstorm merged 76 commits intomainumccr/htsget-rs:mainfrom better_ciumccr/htsget-rs:better_ciCopy head branch name to clipboardJan 15, 2023

+508-368

Commits

Commits on Jun 14, 2022

• Trim the whole GHA, use https://github.com/umccr/reusable-github-actions

  brainstorm

  committed
  d6f9dd5

• Repoint reusable workflows as per https://github.com/umccr/htsget-rs/actions/runs/2493214340

  brainstorm

  committed
  e2cb2a5

• Comment indirection

  brainstorm

  committed
  dea2bef

• derive Eq along w/ PartialEq: https://github.com/umccr/htsget-rs/runs/6875010856?check_suite_focus=true#step:5:455

  brainstorm

  committed
  1926d93

• Comment the test and benchmarks for now, need to implement dependencies w/ reusable workflows, see https://stackoverflow.com/questions/58457140/dependencies-between-workflows-on-github-actions and h…

  Show description for 1c40a03
  brainstorm

  committed
  1c40a03

Commits on Jun 15, 2022

• PartialEq, Eq errors

  brainstorm

  committed
  3afe447

• Hopefully done with that Eq lint?

  brainstorm

  committed
  28345c5

Commits on Jun 16, 2022

• Remove stray char in Cloud

  brainstorm

  committed
  05b528f

Commits on Jun 20, 2022

• Avoid duplicate CI runs

  brainstorm

  committed
  a63c889

• Check passes, let's go for testing phase

  brainstorm

  committed
  dd4c794

• Add job dependencies and drafting release module

  brainstorm

  committed
  dd60301

• Enable benchmarking phase

  brainstorm

  committed
  9d0c603

• Trigger run

  brainstorm

  committed
  fa3f2a3

• Redundant comment

  brainstorm

  committed
  83fbc40

• Add a couple of TODO, test cargo-install for multiple crates at once

  brainstorm

  committed
  7772201

• Will use slim Rust container for

  brainstorm

  committed
  b2dbe78

• Need to get acquainted with conventional commits too, TODO

  brainstorm

  committed
  6d441a2

• Not fully convinced about shipping Docker too for devs, but giving it a go

  brainstorm

  committed
  52cb45d

Commits on Jun 21, 2022

• Adjust timing and number of samples to avoid criterion warnings/runouts, both locally and on the target CI environment (GHA).

  brainstorm

  committed
  44a7ac8

• Benches closer to plots with this PR

  brainstorm

  committed
  56dcdd8

• Original htsnexus implementation is gone from DNANexus, @mlin? /cc @ohofmann

  brainstorm

  committed
  b13c6f9

Commits on Jun 23, 2022

• Commits are non-convetional still, but let's try the request/search benchmarks and see if release PR is working

  brainstorm

  committed
  2c6a383

• Move rusable bits away from this repo

  brainstorm

  committed
  358baf2

• Release should depend on benchmarking regressions too

  brainstorm

  committed
  f17f51b

Commits on Dec 14, 2022

• Merge branch 'main' into better_ci

  brainstorm

  committed
  e499902

• futures.push_back might have been deprecated? Switching to .push

  brainstorm

  committed
  514dff4

Commits on Dec 15, 2022

• Inline format arguments (make clippy happy)

  brainstorm

  committed
  acb549c

• Cargo fmt

  brainstorm

  committed
  157b46b

• Back pedal on push vs push_back (the former actually being the one being deprecated :-S)... more inline format clippy warnings that do not show locally despite cargo clean-ing and making sure same …

  Show description for c9b92ce
  brainstorm

  committed
  c9b92ce

• More inline format strings

  brainstorm

  committed
  251771d

• Fixup clippy on nightly too, not only stable

  brainstorm

  committed
  b573d0c

Commits on Dec 16, 2022

• Ignore secrets and data

  brainstorm

  committed
  e755f42

• Clarify which lambda runtime we are using

  brainstorm

  committed
  52fae72

• cargo clippy --fix for all features

  brainstorm

  committed
  272c1a4

• Cargo clippy --fix has been stabilised now

  brainstorm

  committed
  0fde7f3

• Get rid of reusable workflows strategy

  brainstorm

  committed
  ae0c09d

Commits on Dec 19, 2022

• Focus on search benchmarks generation and storage

  brainstorm

  committed
  ad7ea00

• auto-push must be false when external-data-json-path is set since this action reads/writes the given JSON file and never pushes to remote

  brainstorm

  committed
  4b56ab1

• Is the benchmark output being generated on stderr instead of stdout?

  brainstorm

  committed
  0ecf6d6

• Update secret accordingly, valid only for 1 year for now

  brainstorm

  committed
  bc0ac01

Commits on Dec 20, 2022

• Undo stdout/stderr redirection for search-benchmarks

  brainstorm

  committed
  6f7af68

• Going a bit more verbatim on github-action-benchmark docs, perhaps missed some assumption/convention?

  brainstorm

  committed
  28d4a0c

• Where is the benchmark output.txt and why is it not found?

  brainstorm

  committed
  88f7caf

• Repeated htsget-rs/htsget-rs path segment in https://github.com/umccr/htsget-rs/actions/runs/3737593760/jobs/6342928802#step:9:17...

  brainstorm

  committed
  a5e36d2

• Hopefully correct path now/

  brainstorm

  committed
  9b256e9

Commits on Dec 21, 2022

• Hardcode output.txt path on the runner directory

  brainstorm

  committed
  0a1439d

Commits on Dec 22, 2022

• Test github-action-benchmark fork and cargo-criterion tool feature outlinedi n benchmark-action/github-action-benchmark#145

  brainstorm

  committed
  2239c74

• Use the right branch for the forked action

  brainstorm

  committed
  94382af

Commits on Dec 23, 2022

• Forked GHA requires a runnable release to work

  brainstorm

  committed
  820fc92

Commits on Jan 3, 2023

• Test custom cargo criterion release: does the GHA refer to tags/releases or branches?

  brainstorm

  committed
  a62fcc4

Commits on Jan 4, 2023

• Test all the changes introduced in the GHA

  brainstorm

  committed
  6b5bed7

Commits on Jan 5, 2023

• Testing native benchmark report keeping

  brainstorm

  committed
  212fd88

• Newer checkout migrates from deprecated Node12 to Node16

  brainstorm

  committed
  fd1cdff

• Merge branch 'main' into better_ci

  brainstorm

  committed
  d5b4c2e

• Merge conflicts

  brainstorm

  committed
  5b09498

• Add release-plz, first run

  brainstorm

  committed
  2c254a3

• error: all dependencies must have a version specified when publishing.

  brainstorm

  committed
  76ee9ad

• [skip ci] Repoint dependencies to its respective repos instead of local paths, in preparation for (manual) crates.io release

  brainstorm

  committed
  76fe060

• he remote server responded with an error: missing or empty metadata fields: description, license. Please see https://doc.rust-lang.org/cargo/reference/manifest.html for how to upload metadata

  brainstorm

  committed
  77b7772

• Add missing licenses/descriptions pre-crates.io publishing [ci skip]

  brainstorm

  committed
  a9993b0

• Adding the rest of attributes to avoid cargo publish warnings [ci skip]

  brainstorm

  committed
  a80128f

• Last metadata addition to avoid cargo publish warnings on htsget-test-utils crate [ci skip]

  brainstorm

  committed
  f06b2d2

Commits on Jan 6, 2023

• Rename htsget-http-actix -> htsget-actix, htsget-http-lambda -> htsget-lambda, htsget-http-core -> htsget-http, and htsget-test-utils -> htsget-test

  mmalenic

  committed
  a017b88

• Version bump all deps

  brainstorm

  committed
  98ba11a

• Better names for the lib side of this crate

  brainstorm

  committed
  208097d

• Cleanup before release as described in release-plz/action#14 (comment)

  brainstorm

  committed
  65fcc29

• Temporarily disable htsget-test as suggested by cargo maintainers

  brainstorm

  committed
  585485e

• Revert "Temporarily disable htsget-test as suggested by cargo maintainers"

  Show description for a9e9565
  brainstorm

  committed
  a9e9565

• Stray fmt

  brainstorm

  committed
  b059b56

• Cargo clippy

  brainstorm

  committed
  c2d29f8

• This cargo fmt did not go through?

  brainstorm

  committed
  ecc1d00

Commits on Jan 7, 2023

• Only trigger on those branches as I'm testing, thanks @Marcoleni, let's see what happens now :)

  brainstorm

  committed
  48b16a0

• Split monolith GHA workflow into 3 actions, was running out of space by release

  brainstorm

  committed
  18b755b

• Drop custom generate token for release-plz

  brainstorm

  committed
  b9a2fbd

Commits on Jan 9, 2023

• No more than 1 level for tests and benchmarks [ci skip]

  brainstorm

  committed
  f365aed

Commits on Jan 15, 2023

• Merge deploy conflict(s)

  brainstorm

  committed
  6b3ad15