-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: additional features to make configuration simpler #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge type without manually specifying config values
…, and rearrange modules
…sing the `Config`
…lementation for it
…ex capture groups
mmalenic
commented
Mar 20, 2023
brainstorm
approved these changes
Mar 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Marko, thanks for this!
Slightly concerned about the move to have the s3-storage
feature as default, but it might simplify setup, so I'm okay with it. Ship it! ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly a reorganization and refactor of code, however there are some new features.
Changes
'^(?P<bucket>.*)/(?P<key>.*)$'
in order to use the first component of the id as the bucket.type
parameter is removed, and the configuration of storage is now untagged.HtsGetFromStorage
andSearch
is much simpler on thehtsget-search
side - most of the storage resolution now happens inhtsget-config
.HttpTicketFormatter
and removed theUrlFormatter
implementation on it, as this concept is represented by thehtsget-config
LocalStorage
.htsget-search
tohtsget-config
. Most of these should be removed when noodles-htsget based refactor #89 is addressed.serve_at
field not being used when configuring the local data server.