Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow populating event's createdAt on the send endpoint #3157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DavidVentura
Copy link

Related to #3156, this change allows passing createdDate on the /api/send endpoint, to specify when the event took place.
This feature is useful to import historical access logs into umami.

I've manually tested the changes with a postgres database

Copy link

vercel bot commented Jan 6, 2025

Someone is attempting to deploy a commit to the umami-software Team on Vercel.

A member of the Team first needs to authorize it.

@mikecao
Copy link
Collaborator

mikecao commented Jan 10, 2025

Date strings are always tricky. I think this would work better as a number, unix time in milliseconds, the same as calling Date.now().

@DavidVentura
Copy link
Author

That was my initial implementation, but then saw yup supports validating strings as dates.

I don't have a preference to be honest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants