Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle certificate chains #30

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Handle certificate chains #30

merged 1 commit into from
Mar 12, 2024

Conversation

shreyav
Copy link
Contributor

@shreyav shreyav commented Mar 11, 2024

No description provided.

@shreyav shreyav requested a review from jklein24 March 11, 2024 18:43
val signingCertificate: X509Certificate?,
@Serializable(with = X509CertificateSerializer::class)
val encryptionCertificate: X509Certificate?,
val signingCertChain: List<@Serializable(with = X509CertificateSerializer::class) X509Certificate>?,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah, I didn't know you could do this with serializable lists. Cool.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same I'm learning something new everyday 😂

@shreyav shreyav merged commit 775775a into release/v1.0 Mar 12, 2024
2 checks passed
@shreyav shreyav deleted the fix/certchain branch March 12, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants