x509 certificates for validation #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklein24
approved these changes
Mar 6, 2024
Comment on lines
+109
to
+111
| // encryptionPubKey.publicKey is an ASN.1/DER encoded X.509/SPKI key, the last 65 | ||
| // bytes are the uncompressed public key | ||
| return publicKey.encoded.takeLast(65).toByteArray() |
There was a problem hiding this comment.
Ooh cool :-). This starts with 04 and doesn't include the ---- END BLAH ---- tags, right?
There was a problem hiding this comment.
yes! added an example of what it looks like here https://github.com/uma-universal-money-address/uma-kotlin-sdk/pull/26/files#diff-c3d18805abe410a5e76b66b0d653e58f34ae72a732bb2d5bb85c033f48d98410R30
| assertNotNull(parsedResponse); | ||
| assertEquals(keysOnlyResponse, parsedResponse); | ||
|
|
||
| PubKeyResponse certsOnlyResponse = |
There was a problem hiding this comment.
We should also test a response that has all 4 for the backwards compat case.
There was a problem hiding this comment.
discussed on slack! will handle this alongside backwards compatibility for the other data models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.