Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename fields based on suggestions #46

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

zhenlu
Copy link
Contributor

@zhenlu zhenlu commented Sep 10, 2024

No description provided.

@zhenlu zhenlu marked this pull request as ready for review September 10, 2024 01:35
Copy link
Contributor Author

zhenlu commented Sep 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @zhenlu and the rest of your teammates on Graphite Graphite

@zhenlu zhenlu force-pushed the 09-09-rename_fields_based_on_suggestions branch from 04f3b3e to 344a7ce Compare September 10, 2024 01:38
Copy link
Collaborator

@jklein24 jklein24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small note

uma/protocol/invoice.go Outdated Show resolved Hide resolved
@zhenlu zhenlu force-pushed the 09-09-rename_fields_based_on_suggestions branch from 344a7ce to 1231c32 Compare September 10, 2024 19:10
@zhenlu zhenlu merged commit 7c8d698 into main Sep 10, 2024
3 checks passed
@zhenlu zhenlu deleted the 09-09-rename_fields_based_on_suggestions branch September 10, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants