Add a TLV encoder/decoder. #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklein24
approved these changes
Jul 10, 2024
| } | ||
|
|
||
| type TLVUtilsTests struct { | ||
| StringField string `tlv:"0"` |
| var result []byte | ||
| for i := 0; i < val.NumField(); i++ { | ||
| field := val.Field(i) | ||
| tag := typ.Field(i).Tag.Get("tlv") |
There was a problem hiding this comment.
This is cool! Is this how the json serializing works in Go too?
There was a problem hiding this comment.
Yeah I think json utilize this reflect as well
| field := val.Field(i) | ||
| tag := typ.Field(i).Tag.Get("tlv") | ||
| if tag == "" { | ||
| continue |
There was a problem hiding this comment.
Will this just silently drop those fields? Do you think it should it be an error?
There was a problem hiding this comment.
The consideration is to make it flexible, so not all fields needs to be serialized to TLV.
There was a problem hiding this comment.
One example is that if we ever want to use 2 bytes as type, we can specify it in the struct without TLV field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.