Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define headers #26

Closed
wants to merge 14 commits into from
Closed

Define headers #26

wants to merge 14 commits into from

Conversation

Jamaika1
Copy link
Contributor

No description provided.

@Jovasa
Copy link
Member

Jovasa commented Nov 15, 2024

Why are you checking for AVX512 when all of the optimizations are AVX2?

@Jamaika1
Copy link
Contributor Author

Jamaika1 commented Nov 15, 2024

Hi Jovasa
I use mavx2 and (gcc 11.5.0 or 15.0.0 20241110).
Encoder hevc and vvc didn't want to work and I started looking for the problem.
The guilty function is _mm256_srli_si256 in 'missing-intel-intrinsics.h'. I change define AVX2 in AVX512 and codec works.
I took a look at the functions in simde.
https://github.com/simd-everywhere/simde/blob/master/simde/simde-features.h

#if defined(SIMDE_X86_AVX512F_NATIVE) && !defined(SIMDE_X86_AVX2_NATIVE)
  #define SIMDE_X86_AVX2_NATIVE
#endif
...
#if !defined(SIMDE_X86_AVX2_NATIVE) && !defined(SIMDE_X86_AVX2_NO_NATIVE) && !defined(SIMDE_NO_NATIVE)
  #if defined(SIMDE_ARCH_X86_AVX2)
    #define SIMDE_X86_AVX2_NATIVE
  #endif
#endif
#if defined(SIMDE_X86_AVX2_NATIVE) && !defined(SIMDE_X86_AVX_NATIVE)
  #define SIMDE_X86_AVX_NATIVE
#endif
....
#if defined(SIMDE_X86_AVX2_NATIVE)
#  define simde_mm256_srli_si256(a, imm8) _mm256_srli_si256(a, imm8)
#endif

@Jamaika1 Jamaika1 closed this Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants