Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extra.js #28

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Update extra.js #28

merged 2 commits into from
Nov 21, 2024

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Nov 21, 2024

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhanced theme handling for the Ultralytics Handbook, improving responsiveness to system and user preferences. πŸŒ“

πŸ“Š Key Changes

  • Modularized the theme application logic by introducing an applyTheme function to improve code readability.
  • Adjusted event listener syntax for monitoring system theme preference changes.
  • Improved code formatting and consistency in string literals (using double quotes).

🎯 Purpose & Impact

  • Improved Code Maintainability: By encapsulating theme logic in a function, the code is easier to read and maintain.
  • Enhanced User Experience: The app now more reliably switches themes based on user preference or system settings, providing a seamless visual experience.
  • Consistent Styling: Ensures more consistent styling throughout the documentation by adhering to the set color scheme.

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
handbook βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 21, 2024 11:37pm

@UltralyticsAssistant
Copy link
Member

πŸ‘‹ Hello @glenn-jocher, thank you for submitting an ultralytics/handbook πŸš€ PR! This is an automated response that will be followed by assistance from an Ultralytics engineer soon. To ensure a seamless integration of your contribution, please review the checklist below:

  • βœ… Define a Purpose: Ensure your PR clearly states the purpose of your changes, and link to any relevant issues. Make sure your commit messages are clear and adhere to our project's conventions.
  • βœ… Synchronize with Source: Confirm your branch is up to date with the main branch of the repository. Update it by clicking the 'Update branch' button or by running git pull and git merge main locally to avoid conflicts.
  • βœ… Ensure CI Checks Pass: Verify that all Ultralytics Continuous Integration (CI) checks are passing. Please address any failing checks to ensure a smooth review process.
  • βœ… Update Documentation: If your changes affect the project documentation, make sure to update the relevant sections in the documentation.
  • βœ… Add Tests: Include or update tests to cover your changes and ensure that they pass successfully.
  • βœ… Sign the CLA: If this is your first contribution to Ultralytics, please sign the Contributor License Agreement by commenting "I have read the CLA Document and I sign the CLA" below.
  • βœ… Minimize Changes: Focus your modifications on the essential parts needed for your bug fix or feature implementation. A wise reminder from Bruce Lee: "It is not daily increase but daily decrease, hack away the unessential."

For more information, check our Contributing Guide. Feel free to leave a comment if you have questions or need further assistance. Thank you for enhancing the Ultralytics project! 🌟

@glenn-jocher glenn-jocher merged commit 0dc99fa into main Nov 21, 2024
3 checks passed
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch November 21, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants