Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LIME-54] 아이템 상세조회 기능추가 #23

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

Curry4182
Copy link
Contributor

@Curry4182 Curry4182 commented Jan 24, 2024

📌 PR 종류

어떤 종류의 PR인지 아래 항목 중에 체크 해주세요.

  • 🐛 버그 수정
  • ✨ 기능 추가
  •  테스트 추가
  • 🎨 코드 스타일 변경 (formatting, local variables)
  • 🔨 리팩토링 (기능 변경 X)
  • 💚 빌드 관련 수정
  • 📝 문서 내용 수정
  • 그 외, 어떤 종류인지 기입 바람:

📌 어떤 기능이 추가 되었나요?

  • 아이템 상세조회 할 경우 찜 개수도 함께 반환 되도록 추가하였습니다. 7c5dba2 😊❤
  • 리뷰가 없는 아이템을 상세 조회할 경우 평점이 null에서 0으로 반환 되도록 수정 9e62490 😊❤

Issue Number

LIME-54

반환 json 형식

  • 아이템 상세조회
{
    "itemInfo": {
        "id": 6,
        "name": "Bsun Moon 비선문 투명 리니어 스위치",
        "price": 250,
        "image": "https://shop-phinf.pstatic.net/20231115_7/1700016570031xpelT_JPEG/6564982989305255_1916464417.JPG?type=m510"
    },
    "itemUrl": "https://smartstore.naver.com/pompokey/products/8814129912?NaPm=ct%3Dlpktmvgg%7Cci%3D643183b5ccd7907ac35e9e2aa270bfc2363ffe6b%7Ctr%3Dslsl%7Csn%3D4954554%7Chk%3D60c8b01e78a6d310ccb29fecaa9a175f5e366d02",
    "itemAvgRate": 0.0,
    "isMemberItem": true,
    "isReviewed": false,
    "favoriteCount": 1
}

📌 기존에 있던 기능에 영향을 주나요?

  • 아니요

@Curry4182 Curry4182 added the enhancement New feature or request label Jan 24, 2024
@Curry4182 Curry4182 self-assigned this Jan 24, 2024
Copy link
Member

@Yiseull Yiseull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니당 😊

Comment on lines +12 to +16
double itemAvgRate,
boolean isMemberItem,
boolean isReviewed
) {
boolean isReviewed,
int favoriteCount
) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런 이유에서 기본 값이 사용되는군요...
역시 다양한 요구사항을 생각해야 하는 것들을 배워가네용

@@ -11,7 +11,7 @@ public record MemberItemMetadata (
String itemUrl,
String imageUrl,
int price,
int myItemCount,
int favoriteCount,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 표현이 저도 더 좋아보여요! 굿

@Curry4182
Copy link
Contributor Author

늦은 시간인데 바로 리뷰 해주셔서 감사합니다 평안한 밤 보내세요 ❤

@Curry4182 Curry4182 merged commit aa795ab into main Jan 24, 2024
@Curry4182 Curry4182 deleted the LIME-54-BE-item-detail-feat branch January 24, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants