-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor modification and bug fix in GFS cumulus convection schemes #2487
base: develop
Are you sure you want to change the base?
Conversation
@rhaesung Can I check your holiday PTO schedule this week? If you are available tomorrow, we can schedule to work on this pr. |
@FernandoAndrade-NOAA @BrianCurtis-NOAA #2483 has ACS subcomponent PR as well. I think people will be away for holiday. Instead, can we schedule to work on this pr? @rhaesung can you sync up branches? |
FV3 needs their CM's to approve it. |
There's WW3 changes but no WW3 PR linked. |
Sync issue at WW3. @rhaesung please, go ahead to sync up branches across sub components and weather model level. |
@FernandoAndrade-NOAA @BrianCurtis-NOAA FYI: If @grantfirl @dustinswales are off this week, we may not be able to do merging this week. |
The test_changes.list hasn't been merged properly. |
Commit Queue Requirements:
Description:
This PR includes minor modifications and bug fixes to the GFS cumulus convection schemes, enhancing their performance and addressing identified issues. The code of this PR was provided by @JongilHan66.
Modified prognostic updraft fraction (sigmab) calculation in 'progsigma_calc.f90' which is physically more sound:
a) moisture convergence calculation: integrate from the convection source level rather than from the cloud base
b) 2D advection of sigmab: sigmab advection averaged over the cloud layers rather than taking a maximum sigmab advection from k=2 to the model top
c) To suppress unrealistically large reflectivity in the model first time step, minimum sigmab at the first time step is set to zero
Fix in missing vertical transport of turbulent kinetic energy (TKE) when aerosol transport is turned on (samfdeepcnv.f & samfshalcnv.f)
Introduce TKE at model layer interfaces (tkeh) for use in convection schemes (GFS_typedefs.F90, GFS_typedefs.meta, satmedmfvdifq.F, satmedmfvdifq.meta, samfdeepcnv.f, samfdeepcnv.meta, samfshalcnv.f, and samfshalcnv.meta)
Vertical transports of hydrometeor variables are currently not allowed in the convection schemes. But vertical transports of number concentrations of only cloud water and ice are mistakenly allowed, which is fixed in this update (CCPP_typedefs.F90)
All the modifications and bug fixes above had neutral impacts on the GFS forecasts
Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
Testing Log: