Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor modification and bug fix in GFS cumulus convection schemes #2487

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

rhaesung
Copy link

@rhaesung rhaesung commented Oct 31, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR includes minor modifications and bug fixes to the GFS cumulus convection schemes, enhancing their performance and addressing identified issues. The code of this PR was provided by @JongilHan66.

  1. Modified prognostic updraft fraction (sigmab) calculation in 'progsigma_calc.f90' which is physically more sound:
    a) moisture convergence calculation: integrate from the convection source level rather than from the cloud base
    b) 2D advection of sigmab: sigmab advection averaged over the cloud layers rather than taking a maximum sigmab advection from k=2 to the model top
    c) To suppress unrealistically large reflectivity in the model first time step, minimum sigmab at the first time step is set to zero

  2. Fix in missing vertical transport of turbulent kinetic energy (TKE) when aerosol transport is turned on (samfdeepcnv.f & samfshalcnv.f)

  3. Introduce TKE at model layer interfaces (tkeh) for use in convection schemes (GFS_typedefs.F90, GFS_typedefs.meta, satmedmfvdifq.F, satmedmfvdifq.meta, samfdeepcnv.f, samfdeepcnv.meta, samfshalcnv.f, and samfshalcnv.meta)

  4. Vertical transports of hydrometeor variables are currently not allowed in the convection schemes. But vertical transports of number concentrations of only cloud water and ice are mistakenly allowed, which is fixed in this update (CCPP_typedefs.F90)

  5. All the modifications and bug fixes above had neutral impacts on the GFS forecasts

Commit Message:

* UFSWM - 
  * FV3 - 
    * ccpp-physics - 

Priority:

  • Normal

Git Tracking

UFSWM:

  • None

Sub component Pull Requests:



Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@jkbk2004
Copy link
Collaborator

@rhaesung Can I check your holiday PTO schedule this week? If you are available tomorrow, we can schedule to work on this pr.

@rhaesung
Copy link
Author

@rhaesung Can I check your holiday PTO schedule this week? If you are available tomorrow, we can schedule to work on this pr.

@jkbk2004 I will work tomorrow.

@jkbk2004
Copy link
Collaborator

@FernandoAndrade-NOAA @BrianCurtis-NOAA #2483 has ACS subcomponent PR as well. I think people will be away for holiday. Instead, can we schedule to work on this pr? @rhaesung can you sync up branches?

@BrianCurtis-NOAA
Copy link
Collaborator

FV3 needs their CM's to approve it.

@BrianCurtis-NOAA
Copy link
Collaborator

There's WW3 changes but no WW3 PR linked.

@jkbk2004
Copy link
Collaborator

Sync issue at WW3. @rhaesung please, go ahead to sync up branches across sub components and weather model level.

@jkbk2004
Copy link
Collaborator

@FernandoAndrade-NOAA @BrianCurtis-NOAA FYI: If @grantfirl @dustinswales are off this week, we may not be able to do merging this week.

@DeniseWorthen
Copy link
Collaborator

DeniseWorthen commented Nov 25, 2024

The test_changes.list hasn't been merged properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants