Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add developmental test cases: idealized baroclinic wave and 2020 July CAPE cases + https://github.com/ufs-community/ufs-weather-model/pull/2459 #2461

Merged
merged 132 commits into from
Nov 12, 2024
Merged

Add developmental test cases: idealized baroclinic wave and 2020 July CAPE cases + https://github.com/ufs-community/ufs-weather-model/pull/2459 #2461

merged 132 commits into from
Nov 12, 2024

Conversation

ulmononian
Copy link
Collaborator

@ulmononian ulmononian commented Oct 10, 2024 •
edited by jkbk2004
Loading

Commit Queue Requirements:

  • Fill out all sections of this template.

  • All sub component pull requests have been reviewed by their code managers.

  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
    RegressionTests_hera.log

  • Commit 'test_changes.list' from previous step

Description:

Add ATM-only idealized dry baroclinic wave test and a 2020 July CAPE case study from the UFS Case Studies page. The baroclinic wave is run at C192 resolution; 2020 July CAPE currently at C48 resolution using v2 surface files. The cases can be run from inside the tests-dev directory. Currently, both cases are enabled on Orion and Hera, but will be ported to other Tier 1 platforms in the near term.

Configuration details:

2020 July CAPE:

  • ATM-only
  • Resolution: C48
  • default CCPP suite: FV3_GFS_v16
  • ICs: GFSv16 input data generated manually with UFS_UTILS (v2 sfc files)

Baroclinic wave:

  • ATM-only
  • Resolution: C192
  • default CCPP suite: (dycore only)
  • ICs: currently uses default for C192 from INPUT_L127_gfsv17; INPUT data is only used to enable model to run

The baroclinic wave case utilizes a model configuration provided by @XiaqiongZhou-NOAA at NOAA EMC, who also kindly provided information and an example of how to configure the case. The input namelist for this case can be found here.

Testing and porting of this work done in collaboration with @natalie-perlin.

Commit Message:

* UFSWM - Add tests-dev ATM-only idealized dry baroclinic wave test and a 2020 July CAPE case
* UFSWM - Update modulefile to support Rocky 8 on CSPs, with ParallelWorks

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

  • None

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Adds New Tests/Baselines.

Input data Changes:

  • New input data: GFS ICs for 2020 July CAPE case; global_hyblev.l128.txt file for baroclinic wave remapping

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

weihuang-jedi and others added 30 commits August 30, 2024 23:21
@weihuang-jedi
make ufs model compile on CSPs with Rocky 8
9c60f80
@weihuang-jedi
Merge branch 'develop' of github.com:NOAA-EPIC/ufs-weather-model into…
30893c0 
… csps-rocky8
@jkbk2004
update test yaml
48d4d91
@jkbk2004
Merge branch 'ufs-community:develop' into feature/jedi-build
79b5b4b
@jkbk2004
update utils scirpt: jedi build
d299ba5
@jkbk2004
Create compile_slurm_jedi.IN_hera
ab33fd7
@jkbk2004
Create ufs_bundle.yaml
5c6d960
@jkbk2004
Create jedi_slurm.IN_hera
f4a8754
@ulmononian
Bring in updated test_cases directory structure from old branch. Port…
636d8ba 
… in some 2020_CAPE and BCW192 configurations; Updae ufs_test.yaml to include test_cases build options.
@ulmononian
Add logic to copy test_case configurations to symlinked tests/fv3_con…
bdc2a0b 
…f/parm; update 2020_CAPE test file.
@ulmononian
Remove control_run.IN from test_cases/fv3_conf.
17b6530
@jkbk2004
Merge branch 'ufs-community:develop' into feature/jedi-build
2841c7b
@jkbk2004
update test yaml
d8c1d0c
@ulmononian
Merge branch 'ufs-community:develop' into feature/enable_test_cases
d180247
@ulmononian
Add BCW192 fv3_conf and nml; update BCW192 test file.
ca31cd1
@ulmononian
Merge branch 'ufs-community:develop' into feature/enable_test_cases
33d4746
@ulmononian
Change fv3_conf dir name and bcw IN file title.
e74709a
@ulmononian
Rename 2020_CAPE.IN.
f4db42b
@ulmononian
Fix CICE hash.
843fe6b
@ulmononian
Update ufs_test.sh to use exp_conf.
52a37c1
@ulmononian
Update baroclinic wave tests file.
f590477
@ulmononian
Update bcw nml and test file.
914f177
@ulmononian
Updates.
6b1a424
@jkbk2004
Merge branch 'ufs-community:develop' into feature/jedi-build
fdabfd8
@jkbk2004
Update machine_orion.config
c419652
@weihuang-jedi
remove unneeded path
2b66c95
@weihuang-jedi
remove unneeded path
95fb82b
@jkbk2004
Update machine_orion.config
3304451
@jkbk2004
update log py: pass check
b599e33
@ulmononian
Merge branch 'ufs-community:develop' into feature/enable_test_cases
a9bde34
@jkbk2004 jkbk2004 changed the title Add developmental test cases: idealized baroclinic wave and 2020 July CAPE cases + Update inline post #2489 + https://github.com/ufs-community/ufs-weather-model/pull/2459 Add developmental test cases: idealized baroclinic wave and 2020 July CAPE cases + https://github.com/ufs-community/ufs-weather-model/pull/2459 Nov 12, 2024
@jkbk2004 jkbk2004 added Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. Baseline Updates Current baselines will be updated. New Baselines New baselines will be added to project. and removed Baseline Updates Current baselines will be updated. labels Nov 12, 2024
@WenMeng-NOAA
Copy link
Contributor

@WenMeng-NOAA #2489 is combined to this pr.

@jkbk2004 Thanks!

@ulmononian Could you incorporate this change from #2489? Thanks!

@jkbk2004
Copy link
Collaborator

Rocoto is not stable on Gaea and Derecho. But baselines of develop-20241031 on those machines are ok.

@ulmononian
Copy link
Collaborator Author

@NickSzapiro-NOAA would you be able to resolve the comments if you are ok with the replies?

jkbk2004
jkbk2004 approved these changes Nov 12, 2024
View reviewed changes
tests-dev/test_cases/test_cases.yaml Outdated Show resolved Hide resolved
tests-dev/test_cases/exp_conf/2020_CAPE.IN Outdated Show resolved Hide resolved
tests-dev/test_cases/exp_conf/2020_CAPE.IN Show resolved Hide resolved
@jkbk2004 jkbk2004 merged commit 29c2703 into ufs-community:develop Nov 12, 2024
4 checks passed
@NickSzapiro-NOAA
Copy link
Collaborator

@ulmononian I don't have permissions to resolve comments. Anyways, thanks for the revisions!

tsga added a commit to tsga/ufs-weather-model that referenced this pull request Nov 13, 2024
@tsga
Merge branch 'develop' into feature/lnd_iau
00e041e 
* develop:
  Add developmental test cases: idealized baroclinic wave and 2020 July CAPE cases + ufs-community#2459 (ufs-community#2461)
  Enable some of the intel llvm tests in rt conf + Second reconciliation PR from production/RRFS.v1 ufs-community#2481 (ufs-community#2458)
  Fix/cpld sfs rt + Pull in units updates from FV3 ufs-community#2467 (ufs-community#2475)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickSzapiro-NOAA NickSzapiro-NOAA NickSzapiro-NOAA left review comments

@FernandoAndrade-NOAA FernandoAndrade-NOAA FernandoAndrade-NOAA approved these changes

@zach1221 zach1221 zach1221 approved these changes

@jkbk2004 jkbk2004 jkbk2004 approved these changes

@BrianCurtis-NOAA BrianCurtis-NOAA Awaiting requested review from BrianCurtis-NOAA

Assignees
No one assigned
Labels
New Baselines New baselines will be added to project. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration of UFS Case Studies ICs into UFS-WM
7 participants
@ulmononian @jkbk2004 @WenMeng-NOAA @NickSzapiro-NOAA @zach1221 @FernandoAndrade-NOAA @weihuang-jedi