Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change FVCOM background IO to read 32-bit surface restart files. #848

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

hu5970
Copy link
Contributor

@hu5970 hu5970 commented Aug 30, 2023

DESCRIPTION OF CHANGES:

RRFS uses 32-bit CCPP and it generates 32-bit surface restart file instead of 64-bit restart files.
This requires to change the interface of FVCOM to read 32-bit variables instead of 64-bit variables.

TESTS CONDUCTED:

If there are changes to the build or source code, the tests below must be conducted. Contact a repository manager if you need assistance.

  • Compile branch on all Tier 1 machines using Intel (Orion, Jet, Hera and WCOSS2). Done using 13b5583.
  • Compile branch on Hera using GNU. Done using 13b5583.
  • Compile branch in 'Debug' mode on WCOSS2. Done on Cactus using 13b5583.
  • Run unit tests locally on any Tier 1 machine. Done on Hera using 13b5583.
  • Compile with doxygen - Done on Hera using 13b5583.

Describe any additional tests performed.

  • Tested on WCOSS2 with RRFS real-time runs.

Note: this code does not have any consistency tests.

ISSUE:

Fixes issue mentioned in #847

@GeorgeGayno-NOAA
Copy link
Collaborator

Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test won't compile.

@hu5970
Copy link
Contributor Author

hu5970 commented Aug 31, 2023

@GeorgeGayno-NOAA Could you tell me how to find error message?

@GeorgeGayno-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA Could you tell me how to find error message?

In the build_all.sh script, set -DBUILD_TESTING=ON.

@GeorgeGayno-NOAA
Copy link
Collaborator

@hu5970 What is the status of this?

@hu5970
Copy link
Contributor Author

hu5970 commented Sep 14, 2023

@GeorgeGayno-NOAA George, I am on vacation this week and next week. I will try "-DBUILD_TESTING=ON" if I have time but my response will be slow. Thanks, Ming

@GeorgeGayno-NOAA
Copy link
Collaborator

@GeorgeGayno-NOAA George, I am on vacation this week and next week. I will try "-DBUILD_TESTING=ON" if I have time but my response will be slow. Thanks, Ming

It is working now.

Copy link
Collaborator

@dmwright526 dmwright526 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, @hu5970! It looks like it is passing the unit test.

@GeorgeGayno-NOAA
Copy link
Collaborator

@hu5970 Let me do a few final checks. Then, we can merge.

Copy link
Collaborator

@GeorgeGayno-NOAA GeorgeGayno-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments addressed by developer. All tests passed. Will merge.

@hu5970
Copy link
Contributor Author

hu5970 commented Oct 4, 2023

@GeorgeGayno-NOAA @dmwright526 Thanks. Ming

@GeorgeGayno-NOAA GeorgeGayno-NOAA merged commit 751bb18 into ufs-community:develop Oct 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants