Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove padding from python struct packing #1150

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Remove padding from python struct packing #1150

merged 1 commit into from
Mar 2, 2024

Conversation

andrew-aj
Copy link
Member

Description

Changes the sub9 usb to can board driver and drivers that run on it to remove padding from the structs that are created. Currently, native padding is used which causes "Bf" for example to be 8 bytes instead of 5. This solves this by adding "=" to the beginning of the payload strings to enforce no padding.

Screenshot or Video

Related Issues

Testing

About This PR

  • I have updated documentation related to this change so that future members are aware of the changes I've made.

@uf-mil-bot
Copy link
Collaborator

uf-mil-bot commented Mar 1, 2024

Hola, your friendly InvestiGator bot here with another message!

Because this PR was closed/merged, I'm going to remove the docs preview for now.

Have a great day! Go gators! 🐊

Copy link
Member

@cbrxyz cbrxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks andrew!

@cbrxyz cbrxyz merged commit 39b1637 into master Mar 2, 2024
5 checks passed
@cbrxyz cbrxyz deleted the padding_fix branch March 2, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants