Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wayfinding optimization #1101

Merged
merged 5 commits into from
Nov 6, 2023
Merged

Wayfinding optimization #1101

merged 5 commits into from
Nov 6, 2023

Conversation

DaniParr
Copy link
Contributor

Description

I optimized the wayfinding task accuracy by 50%. I did not change the logic of the code drastically, I simply split the steps taken by the Navigator to get to the waypoint. The 0.85 - 0.15 split means that 85% of the lengths in the x and y directions covered, the Navigator comes to a stop, and then I tell it to finish the final 15% of the path, giving it a chance to readjust

Screenshot or Video

proof

Related Issues

Closes #1078
- Closes #XXX

Testing

Open two terminal windows ->
window 1: roslaunch navigator_launch vrx.launch run_task:=False world:=wayfinding_task --screen
window 2: mission run Vrx

About This PR

The documentation is up to date.

  • [ X] I have updated documentation related to this change so that future members are aware of the changes I've made.

@DaniParr DaniParr requested a review from cbrxyz October 26, 2023 20:06
Copy link
Member

@cbrxyz cbrxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, great job! I tested it and it works great. Please just remember to remove your comments, and run your code through pre-commit to ensure it has a consistent style: https://uf-mil.github.io/docs/software/devtools.html#pre-commit

@cbrxyz
Copy link
Member

cbrxyz commented Oct 26, 2023

Once this is merged in, we can close Task 2 for VRX.

Copy link
Member

@cbrxyz cbrxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@kawaiiPlat kawaiiPlat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cbrxyz cbrxyz merged commit b3ca7c4 into master Nov 6, 2023
2 of 3 checks passed
@cbrxyz cbrxyz deleted the wayfinding_optimization branch November 6, 2023 19:21
@uf-mil-bot
Copy link
Collaborator

Hola, your friendly InvestiGator bot here with another message!

Because this PR was closed/merged, I'm going to remove the docs preview for now.

Have a great day! Go gators! 🐊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task 2: Wayfinding
4 participants