-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#38 Implement a dark mode #241
Conversation
…)` as we already have it loaded on the build function
Thanks! This is awesome! I'll try to give a review tomorrow. |
…rs can see that it exists
# Conflicts: # feedback/test/golden_images/open_feedback.png
I updated my branch to get the latest changes, the workflow should pass now 😄 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #241 +/- ##
==========================================
- Coverage 85.87% 84.10% -1.78%
==========================================
Files 20 20
Lines 616 648 +32
==========================================
+ Hits 529 545 +16
- Misses 87 103 +16
☔ View full report in Codecov by Sentry. |
👋 @ueman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again. The current CI failures are indeed unrelated to this PR
colorScheme: feedbackThemeData.brightness == Brightness.dark | ||
? ColorScheme.dark(background: feedbackThemeData.background) | ||
: ColorScheme.light(background: feedbackThemeData.background)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably go into the theme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried a different approach for this one, let me hear your thoughts! 😄
Hey, thanks again, this is a great improvement. Sorry for the delay 😓 |
📜 Description
ThemeMode
system to determine which theme to useCloses #38
Light mode (no changes)
Dark mode 🌙
💡 Motivation and Context
The package is currently stuck to light mode by default and needs the developers to implement their own dark mode which will not be perfect (the control panel will stay light). This PR fixes it!
By default, a dark mode will be provided and the developers can customize it and also control the [ThemeMode]!
💚 How did you test it?
Added some golden tests to check the dark mode
📝 Checklist
🔮 Next steps