fix: extension link object replacement caracter sanitization #5887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexvcasillas
added
Type: Bug
🦋 Changeset detectedLatest commit: 3e5d682 The changes in this PR will be included in the next version bump. This PR includes changesets to release 54 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@tiptap/core
@tiptap/extension-bold
@tiptap/extension-blockquote
@tiptap/extension-bubble-menu
@tiptap/extension-bullet-list
@tiptap/extension-character-count
@tiptap/extension-code
@tiptap/extension-code-block
@tiptap/extension-code-block-lowlight
@tiptap/extension-collaboration
@tiptap/extension-collaboration-cursor
@tiptap/extension-color
@tiptap/extension-document
@tiptap/extension-dropcursor
@tiptap/extension-floating-menu
@tiptap/extension-focus
@tiptap/extension-font-family
@tiptap/extension-gapcursor
@tiptap/extension-hard-break
@tiptap/extension-heading
@tiptap/extension-highlight
@tiptap/extension-history
@tiptap/extension-horizontal-rule
@tiptap/extension-image
@tiptap/extension-italic
@tiptap/extension-link
@tiptap/extension-list-item
@tiptap/extension-list-keymap
@tiptap/extension-mention
@tiptap/extension-ordered-list
@tiptap/extension-paragraph
@tiptap/extension-placeholder
@tiptap/extension-strike
@tiptap/extension-superscript
@tiptap/extension-subscript
@tiptap/extension-table
@tiptap/extension-table-header
@tiptap/extension-table-cell
@tiptap/extension-table-row
@tiptap/extension-task-item
@tiptap/extension-task-list
@tiptap/extension-text
@tiptap/extension-text-align
@tiptap/extension-text-style
@tiptap/extension-typography
@tiptap/extension-underline
@tiptap/extension-youtube
@tiptap/html
@tiptap/pm
@tiptap/react
@tiptap/starter-kit
@tiptap/suggestion
@tiptap/vue-2
@tiptap/vue-3
commit: |
nperez0111
reviewed
Nov 29, 2024
.changeset/unlucky-ravens-build.md
Outdated
| "@tiptap/extension-link": patch | ||
| --- | ||
|
|
||
| object replacement character sanitization |
There was a problem hiding this comment.
Would be good to include issue #, and a little clearer description
nperez0111
approved these changes
Nov 29, 2024
| // Therefore, linkifyjs does not recognize the | ||
| // link properly. We replace these characters | ||
| // with regular spaces to fix this issue. | ||
| const links = find(text.replaceAll('\uFFFC', ' ')).filter( |
There was a problem hiding this comment.
Did we figure out if this char is valid in a URL? If not, may want to try to upstream this to linkify
There was a problem hiding this comment.
This char won't work if you paste it on any URL, it would be serialized for the URL but would count as a character in the URL and it won't work
There was a problem hiding this comment.
Reported to linkifyjs nfrasser/linkifyjs#495
nperez0111
approved these changes
Nov 29, 2024
nperez0111
deleted the
fix/extension-link-object-replacement-character
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
Prosemirror replaces zero-width non-joiner characters with Object Replacement Character from unicode. Therefore, linkifyjs does not recognize the link properly. We replace these characters with regular spaces to fix this issue.
Implementation Approach
Special Character Replacement
Testing Done
Tested within the demo with the provided content that produced the issue
Verification Steps
N/AAdditional Notes
N/AChecklist
Related Issues
#5679