fix: Don't init when editor is destroyed #4029
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
Adds a check to see if the
EditorContent
editor is already destroyed wheninit
is called. This can happen due to usingReact.StrictMode
where the editor is re-rendered back-to-back automatically by React.How did you accomplish your changes
Extended the existing check to include verifying that the editor hasn't already been destroyed.
How have you tested your changes
Manual testing.
How can we verify your changes
Unfortunately, I don't have a clean reproduction available at this time.
Remarks
Checklist
Related issues
This issue is similar to the various problems described in #1451 (and other linked issues in that thread) and manifests itself with the same
TypeError: Cannot read property 'matchesNode' of null
.