Fix/tick rate #194
Merged
Fix/tick rate #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmin12
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch kind of fixes the tick rate
it fixes an O(n) iteration in the shared game state generation where it was still calling toShared on every single object regardless if it was sent down in the delta update
It also tries to enable a no delay networking mode for the server (wouldnt work on the client)
it also increases the number of objects per packet back to 250 which seems to work in an attempt to fix netwroking related slowdowns
rn we are still experiencing weird tick rate related issues on the demo machines where every so often a tick is missed because sending the packets on the network takes absurdly long
dont know how to solve that, will have to ask tomorrow for help from prof and TA