Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More DM Polish #168

Merged
merged 31 commits into from
Jun 4, 2024
Merged

More DM Polish #168

merged 31 commits into from
Jun 4, 2024

Conversation

EddieJ03
Copy link
Contributor

@EddieJ03 EddieJ03 commented May 29, 2024 •
edited
Loading

  • set item cell to type Empty when picked up - this is so DM can place stuff in that cell now
  • spawn care packages
  • ArrowTrap and SunGod trap with right-click rotation
  • Make lightning bolt first
  • Add visuals for cooldown time in hotbar
  • Remove option to place the directional spike/lava traps (only the full one)
  • Remove needing to press P

BUGS:

This was linked to issues May 29, 2024
Add DM Trap rotation #151
Closed
Care Package Items #158
Closed
@EddieJ03 EddieJ03 changed the base branch from main to dev May 29, 2024 22:14
@jhparkt jhparkt linked an issue May 31, 2024 that may be closed by this pull request
DM Cooldown Timer #171
Closed
@EddieJ03 EddieJ03 linked an issue Jun 2, 2024 that may be closed by this pull request
DM Balance #174
Closed
@EddieJ03 EddieJ03 self-assigned this Jun 3, 2024
@EddieJ03 EddieJ03 marked this pull request as ready for review June 3, 2024 23:30
@EddieJ03 EddieJ03 requested review from Tyler-Lentz and jhparkt June 3, 2024 23:31
Tyler-Lentz
Tyler-Lentz approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@Tyler-Lentz Tyler-Lentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

holy shit, zeus view is so good now

jhparkt
jhparkt approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@jhparkt jhparkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added right click in the control help! everything looks great

@EddieJ03 EddieJ03 merged commit 6251721 into dev Jun 4, 2024
10 of 11 checks passed
@EddieJ03 EddieJ03 deleted the 88-the-dungeon-master branch June 4, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhparkt jhparkt jhparkt approved these changes

@Tyler-Lentz Tyler-Lentz Tyler-Lentz approved these changes

Assignees

@EddieJ03 EddieJ03

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DM Balance DM Cooldown Timer Care Package Items Add DM Trap rotation
3 participants
@EddieJ03 @Tyler-Lentz @jhparkt