remove create part, keep only update

ucraft-com · Sep 13, 2023 · 12ea968 · 12ea968
1 parent 4787454
commit 12ea968
Show file tree

Hide file tree

Showing 7 changed files with 33 additions and 84 deletions.
diff --git a/build/GPBMetadata/Proto/Translation.php b/build/GPBMetadata/Proto/Translation.php
diff --git a/build/TranslationPackage/TranslationItem.php b/build/TranslationPackage/TranslationItem.php
diff --git a/proto/translation.proto b/proto/translation.proto
@@ -25,9 +25,8 @@ message TranslationItem {
     string resource = 5;
     string resource_id = 6;
     string editor = 7;
-    string created_at = 8;
-    string updated_at = 9;
-    map<string, string> params = 10;
+    string updated_at = 8;
+    map<string, string> params = 9;
 }
 
 message OrderBy {

diff --git a/src/Enums/ColumnEnum.php b/src/Enums/ColumnEnum.php
@@ -7,5 +7,5 @@
 enum ColumnEnum: string
 {
     case KEY = 'key';
-    case CREATED_AT = 'created_at';
+    case UPDATED_AT = 'updated_at';
 }
diff --git a/src/TranslationAppClient.php b/src/TranslationAppClient.php
@@ -53,7 +53,6 @@ public function getTranslations(TranslationQueryValueObject $valueObject): array
                     'id'           => $translationItem->getId(),
                     'key'          => $translationItem->getKey(),
                     'value'        => $translationItem->getValue(),
-                    'createdAt'    => $translationItem->getCreatedAt(),
                     'updatedAt'    => $translationItem->getUpdatedAt(),
                     'editor'       => $translationItem->getEditor(),
                     'params'       => $translationItem->getParams(),
@@ -66,27 +65,23 @@ public function getTranslations(TranslationQueryValueObject $valueObject): array
     }
 
     /**
-     * Update translation if id exists, or create new one.
+     * Update translation by id.
      *
      * @param \Uc\TranslationAppSdk\ValueObjects\TranslationItemValueObject $valueObject
      *
      * @return array
      */
-    public function updateOrCreate(TranslationItemValueObject $valueObject): array
+    public function update(TranslationItemValueObject $valueObject): array
     {
         $data = new TranslationItem();
 
-        if ($valueObject->hasId()) {
-            $data->setId($valueObject->getId());
-        }
-
         if ($valueObject->hasParams()) {
             $data->setParams($valueObject->getParams());
         }
 
+        $data->setId($valueObject->getId());
         $data->setKey($valueObject->getKey());
         $data->setValue($valueObject->getValue());
-        $data->setCreatedAt($valueObject->getCreatedAt());
         $data->setUpdatedAt($valueObject->getUpdatedAt());
         $data->setEditor($valueObject->getEditor());
         $data->setResource($valueObject->getResource());
@@ -101,7 +96,6 @@ public function updateOrCreate(TranslationItemValueObject $valueObject): array
                 'id'           => $data->getId(),
                 'key'          => $data->getKey(),
                 'value'        => $data->getValue(),
-                'createdAt'    => $data->getCreatedAt(),
                 'updatedAt'    => $data->getUpdatedAt(),
                 'editor'       => $data->getEditor(),
                 'resource'     => $data->getResource(),

diff --git a/src/ValueObjects/TranslationItemValueObject.php b/src/ValueObjects/TranslationItemValueObject.php
@@ -4,19 +4,18 @@
 
 namespace Uc\TranslationAppSdk\ValueObjects;
 
-class TranslationItemValueObject
+readonly class TranslationItemValueObject
 {
     public function __construct(
-        protected readonly string $key,
-        protected readonly string $value,
-        protected readonly string $languageCode,
-        protected readonly string $createdAt,
-        protected readonly string $updatedAt,
-        protected readonly string $resource,
-        protected readonly int $resourceId,
-        protected readonly string $editor,
-        protected readonly ?int $id,
-        protected readonly ?array $params,
+        protected string $key,
+        protected string $value,
+        protected string $languageCode,
+        protected string $updatedAt,
+        protected string $resource,
+        protected int $resourceId,
+        protected string $editor,
+        protected int $id,
+        protected ?array $params,
     )
     {
     }
@@ -61,14 +60,6 @@ public function getLanguageCode(): string
         return $this->languageCode;
     }
 
-    /**
-     * @return string
-     */
-    public function getCreatedAt(): string
-    {
-        return $this->createdAt;
-    }
-
     /**
      * @return string
      */
@@ -86,21 +77,13 @@ public function getResourceId(): int
     }
 
     /**
-     * @return int|null
+     * @return int
      */
-    public function getId(): ?int
+    public function getId(): int
     {
         return $this->id;
     }
 
-    /**
-     * @return bool
-     */
-    public function hasId(): bool
-    {
-        return !empty($this->getId());
-    }
-
     /**
      * @return array|null
      */

diff --git a/src/ValueObjects/TranslationQueryValueObject.php b/src/ValueObjects/TranslationQueryValueObject.php
@@ -4,16 +4,16 @@
 
 namespace Uc\TranslationAppSdk\ValueObjects;
 
-class TranslationQueryValueObject
+readonly class TranslationQueryValueObject
 {
     public function __construct(
-        protected readonly int $resourceId,
-        protected readonly string $languageCode,
-        protected readonly string $resource,
-        protected readonly ?string $key = null,
-        protected readonly array $orderBy = [],
-        protected readonly int $page = 0,
-        protected readonly int $first = 10,
+        protected int $resourceId,
+        protected string $languageCode,
+        protected string $resource,
+        protected ?string $key = null,
+        protected array $orderBy = [],
+        protected int $page = 0,
+        protected int $first = 10,
     ){
     }