1075 Fix Capybara warning for "Files", discover failing test #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janell-Huyck
changed the title
crowesn
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1075
See PR #1108 for more information about the Capybara warnings.
There was a Capybara warning for
Unused parameters passed to Capybara::Queries::SelectorQuery : ["Files"]. This came from the test at spec/features/form_tab_nav_js_spec.rb:30 that had a parameter "Files" in the have_selector() call. The lack of keyword "text:" caused this parameter to not be used, so the test was only looking for the first item in the query, an active list item.Adding in the keyword "text:" causes the test to fail because the desired behavior is not happening.
I skipped the test because it will not pass without fixing the bug, and have created an issue for the bug, Ref #1121