Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use kebab-case for category deserialization #154

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

d-loose
Copy link
Member

@d-loose d-loose commented Dec 13, 2024

I noticed that update_snap_categories wasn't working when running the ratings server locally:

{"timestamp":"2024-12-13T11:31:42.208055Z","level":"ERROR","message":"unable to update snap categories: Matching variant not found","snap_id":"3wdHCAVyZEmYsCMFDE9qt92UV8rC8Wdk","target":"ratings::ratings::categories","filename":"src/ratings/categories.rs","line_number":55,"threadId":"ThreadId(16)"}

The get_snap_categories_works test (which is skipped in CI since it's sending queries to snapcraft.io) was failing as well.

@d-loose d-loose requested a review from sminez December 13, 2024 12:02
@d-loose d-loose merged commit 897b0bc into ubuntu:main Dec 13, 2024
4 checks passed
@d-loose d-loose deleted the fix-category-conversion branch December 13, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants