feat!: remove obsolete ListMyVotes method
#151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-loose
requested review from
matthew-hagemann and
sminez
and removed request for
matthew-hagemann
matthew-hagemann
approved these changes
Dec 5, 2024
d-loose
added a commit
to ubuntu/app-center
that referenced
this pull request
Dec 17, 2024
Follow-up to ubuntu/app-center-ratings#153 Uses the `snap_name` field added to `Rating` and `Vote` server-side, which eliminates the need to resolve `snap_id`s into `snap_name`s in the app-center. Since this needs a regeneration of the protobuf files, I've also removed the `listMyVotes` methods following ubuntu/app-center-ratings#151. UDENG-5628
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is almost identical to
GetSnapVotes(the difference being that the latter updates the categories in the db). Since it's not being used in the app-center, I think we can safely remove it.