feat: add rockcraft oci image #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-hagemann
force-pushed
the
rockcraft
branch
from
3dac956 to
993f35a
Compare
sminez
reviewed
Aug 14, 2024
rockcraft.yaml
Outdated
| APP_LOG_LEVEL: info | ||
| APP_NAME: ratings | ||
| APP_PORT: 18080 | ||
| APP_JWT_SECRET: "foo" |
There was a problem hiding this comment.
I'm assuming this is a placeholder, but can we have a comment explaining how this is used / overwritten when deployed please?
There was a problem hiding this comment.
I can't actually remember why I left in placeholder originally. I inject a number of ENV vars in the Charm (including most of these), and will know before I run the container all of these variables I need. Let me remove them for now, move this to the Charm and leave out placeholders for readability.
sminez
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
rockcraft.yamland updates pipeline to build and upload it to the ghcrTo clear out some immediate issues with security vulnerabilities I regenerated the
Cargo.lockbut will need to revisit updating some dependencies that introduce breaking changes later.