fix: add pcscd polkit rule for Yubikey access #500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Garrison <[email protected]>
rothgar
changed the title
|
@rothgar thanks for the PR! I wouldn't add this here, instead, we've been adding rules like this to our config RPMs so they can be tracked via RPM database. Side note: the only directly added file in this repo is our systemd-generator for sulogin. Maybe I shouldn't have even added it here, but I did so as I deem it temporary due to our goal of getting it added upstream to either Fedora or systemd itself. It looks like your solution could be a fix to this issue there: ublue-os/config#180 I want to close this PR, but would you mind submitting a PR to https://github.com/ublue-os/config ? It's a bit more involved as it will include tweaking the RPM spec, but I'm happy to walk you through any questions on a PR there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not exactly sure if this should be in /etc/polkit-1/rules.d or /usr/share/polkit-1/rules.d
I put it in /etc/ because it affects a user and this would allow them to change/delete the rule if needed.