Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: consolidate tags to fedora-version #7

Merged
merged 2 commits into from
Jul 10, 2024
Merged

chore: consolidate tags to fedora-version #7

merged 2 commits into from
Jul 10, 2024

Conversation

m2Giles
Copy link
Member

@m2Giles m2Giles commented Jul 10, 2024

Thank you for contributing to the Universal Blue project!

Please read the Contributor's Guide before submitting a pull request.

Copy link
Contributor

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version looks good.

I reviewed all the generated tags.

One thing to note is the SHA tags are only in PR builds(commit-tags) not the "main" build-tags.

Assuming that's intentional, it's good!

@m2Giles
Copy link
Member Author

m2Giles commented Jul 10, 2024

I don't think we need the SHAs since we should be able to just pull by digest after it's been merged if we need a pinned version. The SHAs should be completely redundant tags unless we have some reason to pick a specific commit and don't want to use a digest.

During PRs it's kinda nice, but we aren't pushing the image to ghcr.

Copy link
Member

@EyeCantCU EyeCantCU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me :)

@EyeCantCU EyeCantCU added this pull request to the merge queue Jul 10, 2024
Merged via the queue into main with commit a56fdfe Jul 10, 2024
11 checks passed
@EyeCantCU EyeCantCU deleted the tags branch July 10, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants