Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove Fedora 38 #245

Merged
merged 1 commit into from
Apr 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions .github/workflows/build-38.yml

This file was deleted.

24 changes: 2 additions & 22 deletions .github/workflows/reusable-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ on:
workflow_call:
inputs:
fedora_version:
description: 'The Fedora release version: 38, 39, 40, etc'
description: 'The Fedora release version: 39, 40, etc'
required: true
type: string
env:
Expand Down Expand Up @@ -36,35 +36,19 @@ jobs:
- sericea
- onyx
- base
- lxqt
- lazurite
- mate
- vauxite
image_target:
- main
- nvidia
exclude:
# There is no Fedora 38 version of onyx or lazurite
- image_name: onyx
fedora_version: 38
- image_name: lazurite
fedora_version: 38
# There is no Fedora 39+ version of lxqt as it was replaced by lazurite
- image_name: lxqt
fedora_version: 39
- image_name: lxqt
fedora_version: 40
# There is currently no Fedora 40 version of mate
- image_name: mate
fedora_version: 40
# Don't build/push "main" since it would be a duplicate of the "base" `*-main` images
- kernel_flavor: main
image_target: main
# Only build latest Fedora versions for "asus" and "surface" HWE flavors
- fedora_version: 38
kernel_flavor: asus
- fedora_version: 38
kernel_flavor: surface
steps:
# Checkout push-to-registry action GitHub repository
- name: Checkout Push to Registry action
Expand Down Expand Up @@ -96,11 +80,7 @@ jobs:
TIMESTAMP="$(date +%Y%m%d)"
VARIANT="${{ matrix.fedora_version }}"
if [[ "${{ matrix.fedora_version }}" -eq "38" ]]; then
IS_LATEST_VERSION=false
IS_STABLE_VERSION=true
IS_GTS_VERSION=false
elif [[ "${{ matrix.fedora_version }}" -eq "39" ]]; then
if [[ "${{ matrix.fedora_version }}" -eq "39" ]]; then
IS_LATEST_VERSION=false
IS_STABLE_VERSION=true
IS_GTS_VERSION=true
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# HWE

[![build-38](https://github.com/ublue-os/hwe/actions/workflows/build-38.yml/badge.svg)](https://github.com/ublue-os/hwe/actions/workflows/build-38.yml) [![build-39](https://github.com/ublue-os/hwe/actions/workflows/build-39.yml/badge.svg)](https://github.com/ublue-os/hwe/actions/workflows/build-39.yml) [![build-40](https://github.com/ublue-os/hwe/actions/workflows/build-40.yml/badge.svg)](https://github.com/ublue-os/hwe/actions/workflows/build-40.yml)
[![build-39](https://github.com/ublue-os/hwe/actions/workflows/build-39.yml/badge.svg)](https://github.com/ublue-os/hwe/actions/workflows/build-39.yml) [![build-40](https://github.com/ublue-os/hwe/actions/workflows/build-40.yml/badge.svg)](https://github.com/ublue-os/hwe/actions/workflows/build-40.yml)

The purpose of these images is to provide [community Fedora images](https://github.com/ublue-os/main) with hardware enablement (ASUS and Surface) and Nvidia. This approach can lead to greater reliability as failures can be caught at the build level instead of the client machine. This also allows for individual sets of images for each series of Nvidia drivers, allowing users to remain current with their OS but on an older, known working driver. Performance regression with a recent driver update? Reboot into a known-working driver after one command. That's the goal!

Expand Down
6 changes: 1 addition & 5 deletions nvidia-install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,7 @@ set -ouex pipefail

RELEASE="$(rpm -E %fedora)"

if [[ "${FEDORA_MAJOR_VERSION}" -le 38 ]]; then
sed -i 's@enabled=1@enabled=0@g' /etc/yum.repos.d/fedora-{cisco-openh264,modular,updates-modular}.repo
else
sed -i 's@enabled=1@enabled=0@g' /etc/yum.repos.d/fedora-cisco-openh264.repo
fi
sed -i 's@enabled=1@enabled=0@g' /etc/yum.repos.d/fedora-cisco-openh264.repo

# after F41 launches, bump to 42
if [[ "${FEDORA_MAJOR_VERSION}" -ge 41 ]]; then
Expand Down