feat(just): add option to use toolbox instead of distrobox #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and toolbox the ubi images are identical to the images from registry.redhat.io
|
This is now ready for review |
KyleGospo
approved these changes
Feb 16, 2024
m2Giles
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
toolboxanddistroboxare nowhere near feature parity (and not always compatible with each other), it made more sense to provide the toolbox option as a separate recipe.Recipes
This PR implements the recipes
toolbox-newand a very limited version ofdistrobox-assemblein the form oftoolbox-assemblefor ujust.There are no plans to expand upon this, the assemble feature is provided as a nice to have for defining multiple toolbox containers and assembling them with 1 command.
Internals
For internal ujust functions this implements
Toolbox,ToolboxAssembleandToolboxAssembleListthat will work similar to the internal ujust functions for distrobox.Why make toolbox internal functions?
The easiest maintainable way to generate a list of images is through a similar
inimanifest file like we do for distrobox, we already had the logic for it, so why not re-use it and avoid having to update the script functions/just file whenever the images supplied gets too old.NOTE: Dev container does not have gum or fzf installed, the bash fallback is perfect for demonstration images like this
This should suffice as an implementation for #186