feat(udev): add udev rule for promptless charing threshold changes #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hinkPads only) Allows user to modify the battery charge thresholds without password prompt. The rule was copied from [marcosdalvarez/thinkpad-battery-threshold-extension](https://gitlab.com/marcosdalvarez/thinkpad-battery-threshold-extension).
|
Looks good to me, are there any security implications of regular users being able to do this? Should we limit this to the wheel group? |
|
@KyleGospo I suppose it could be used maliciously. I haven't tried it, but someone could potentially use it to render a laptop temporarily unusable without a charger, i.e. setting a very low charging threshold. |
|
I think that's fair, if you're up for it let's just add a restriction so this only works for wheel |
ispanos
commented
Dec 21, 2023
KyleGospo
approved these changes
Dec 21, 2023
HikariKnight
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows user to modify the battery charge thresholds without password prompt. The rule was copied from marcosdalvarez/thinkpad-battery-threshold-extension. Works only on ThinkPads.