-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add gum helper for choose dialogs #173
Conversation
Is there any more changes i need to do to the spec file since it says it failed to build due to the ugum file missing in the log? 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable.
This looks great!! |
Ok, as long as no more needed changes get requested, this is now feature complete for initial release. The generic bash alternatives are still there in case a user makes a custom image and removes fzf and gum for whatever reason. Any more changes will be done at a later date with their own PR and if support for more menu handlers is desired then it can be added at a later date by people familiar with the said menu handlers (dmenu, rofi, wofi, rofi-wayland, etc) |
This should help start the process of addressing #148 as it will let us provide basic replacement for gum on systems that lack it with minimal options which in turn lets us shrink down the amount of just commands we have greatly.
Currently it only does choose dialogs, but before merging i want to implement the confirm dialog too.
Return values will be identical to what you would expect from gum so in the most basic use cases it will be a 1:1 drop in, assuming you do not need anything more fancy than the defaults from gum.