-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(just): verbose and quiet update messages #167
Conversation
This PR gives some extra options when using
Lets ask the @ublue-os/approver what they think of this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some testing with this and it looks nice.
Thank you for the submission!
@bsherman It continues to say merging is blocked, do I need to do anything else? |
It can be merged after another member of the approval team gives approval. |
Understood, thank you! |
Oh, also @bmp ... can you modify your commit message to be semantic? Instead of "Update 10-update.just" make it something like "feat(just): verbose and quiet update messages" |
Done, made the change, is there a guide somewhere that I could read about appropriate commit messages? |
Ah, you changed the title of the Pull Request. the automation for merge approval is called "Semantic PR" and it's enforcing a standard for our commit messages... https://www.conventionalcommits.org/en/v1.0.0/ The PR title is not the issue it's the commit message itself, which you can see here: https://github.com/ublue-os/config/pull/167/commits Perhaps you can modify your commit message and force push to your repo and that will be reflected here? |
Verbose output with just disable-updates and prompts to update each command
@bsherman Thank you for the tips, I have made the changes and pushed the commit onto my repo. It seems like it passed Semantic PR check now :-). Now it needs another reviewer to approve I guess. |
You're welcome! Thanks for making the changes! I've asked some others to take a look. |
Maybe a text behind the explanation of full like [default] would be good. I as a user sometimes want to know the default without looking into code. |
Verbose output with just disable-updates and prompts to update each command