Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(just): verbose and quiet update messages #167

Merged
merged 1 commit into from
Dec 7, 2023
Merged

feat(just): verbose and quiet update messages #167

merged 1 commit into from
Dec 7, 2023

Conversation

bmp
Copy link
Contributor

@bmp bmp commented Dec 5, 2023

Verbose output with just disable-updates and prompts to update each command

@bobslept
Copy link
Contributor

bobslept commented Dec 5, 2023

This PR gives some extra options when using just update on systems where ublue-update is disabled or not used. As shown below it defaults to full verbosity and also allows you to prompt per command.

~ ❯ just update help
Usage: just update <level>
  <level>: Specify the verbosity level - 'full', 'minimal', or 'prompt'
  Use 'full' to show full output of each command.
  Use 'minimal' to show minimal output and indicate success or failure.
  Use 'prompt' to prompt the user before running each command.

~ ❯ just update
Running rpm-ostree update...
note: automatic updates (stage) are enabled
Pulling manifest: ostree-image-signed:docker://ghcr.io/ublue-os/bluefin-dx:39
No upgrade available.
Completed rpm-ostree update
Running flatpak update -y...
Looking for updates…

Nothing to do.
Completed flatpak update -y
Running distrobox upgrade -a...
Completed distrobox upgrade -a

~ ❯ just update minimal
Running rpm-ostree update...
Completed rpm-ostree update
Running flatpak update -y...
Completed flatpak update -y
Running distrobox upgrade -a...
Completed distrobox upgrade -a

~ ❯ just update prompt
Do you want to run rpm-ostree update? [Y/n]: n
Skipped rpm-ostree update
Do you want to run flatpak update -y? [Y/n]: n
Skipped flatpak update -y
Do you want to run distrobox upgrade -a? [Y/n]: y
Running distrobox upgrade -a...
Completed distrobox upgrade -a

~ ❯ 

Lets ask the @ublue-os/approver what they think of this.

@bobslept bobslept requested a review from a team December 5, 2023 15:59
Copy link
Contributor

@bsherman bsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some testing with this and it looks nice.

Thank you for the submission!

@bmp
Copy link
Contributor Author

bmp commented Dec 7, 2023

@bsherman It continues to say merging is blocked, do I need to do anything else?

@bsherman
Copy link
Contributor

bsherman commented Dec 7, 2023

@bsherman It continues to say merging is blocked, do I need to do anything else?

It can be merged after another member of the approval team gives approval.

@bmp
Copy link
Contributor Author

bmp commented Dec 7, 2023

It can be merged after another member of the approval team gives approval.

Understood, thank you!

@bsherman
Copy link
Contributor

bsherman commented Dec 7, 2023

Oh, also @bmp ... can you modify your commit message to be semantic?

Instead of "Update 10-update.just" make it something like "feat(just): verbose and quiet update messages"

@bmp bmp changed the title feat(just): verbose update messages (modified 10-update.just file) feat(just): verbose and quiet update messages Dec 7, 2023
@bmp
Copy link
Contributor Author

bmp commented Dec 7, 2023

Oh, also @bmp ... can you modify your commit message to be semantic?

Instead of "Update 10-update.just" make it something like "feat(just): verbose and quiet update messages"

Done, made the change, is there a guide somewhere that I could read about appropriate commit messages?

@bsherman
Copy link
Contributor

bsherman commented Dec 7, 2023

Done, made the change, is there a guide somewhere that I could read about appropriate commit messages?

Ah, you changed the title of the Pull Request. the automation for merge approval is called "Semantic PR" and it's enforcing a standard for our commit messages... https://www.conventionalcommits.org/en/v1.0.0/

The PR title is not the issue it's the commit message itself, which you can see here: https://github.com/ublue-os/config/pull/167/commits

Perhaps you can modify your commit message and force push to your repo and that will be reflected here?

Verbose output with just disable-updates and prompts to update each command
@bmp
Copy link
Contributor Author

bmp commented Dec 7, 2023

@bsherman Thank you for the tips, I have made the changes and pushed the commit onto my repo. It seems like it passed Semantic PR check now :-). Now it needs another reviewer to approve I guess.

@bsherman
Copy link
Contributor

bsherman commented Dec 7, 2023

Thank you for the tips,

You're welcome! Thanks for making the changes! I've asked some others to take a look.

@castrojo castrojo added this pull request to the merge queue Dec 7, 2023
Merged via the queue into ublue-os:main with commit d641926 Dec 7, 2023
2 checks passed
@z0rrn
Copy link

z0rrn commented Dec 7, 2023

Maybe a text behind the explanation of full like [default] would be good. I as a user sometimes want to know the default without looking into code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants