-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: check just syntax in build action (fix #152) #155
Conversation
Thanks for both of these, this will catch my dumb mistakes! I need someone more technical to review @ublue-os/approver @ublue-os/member |
Oh sweet, no more broken just ending up on the images! Happened a few times now, big quality improvement! If this works well and is being approved we for sure need this (slightly modified) action in framework and bluefin repo too. |
Thank you for this!! |
@bobslept how many places do we need this in? If it's more than 2-3 it might make sense to not copy-paste the code but instead to make a separate repo with with this action, then we'll be able to just do something like:
|
@ArtikusHG startingpoint would definitely need this |
@fiftydinar it seems like we do need this in many places after all. I will make a separate repo with an action that we can easily include tomorrow. If someone could make a repo for it under the ublue org and give me write access that'd help a lot! |
https://github.com/ublue-os/just-action/ All set, check your emails! Thanks ya'll! |
@ArtikusHG sure is. Would be neat if we can specify the directory where the just files are. Because those differ from repo to repo. |
@bobslept yes I'm planning to do that, the final thing will look something like:
|
That is perfect. Thank you so much! 🥳 |
Please take a look at ublue-os/just-action#1 |
This PR makes the build action fail when
just --fmt --check
fails (#152).Note: currently, none of the justfiles we have here pass the formatting check. #156 must be merged first.