Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check just syntax in build action (fix #152) #155

Merged
merged 3 commits into from
Nov 19, 2023

Conversation

ArtikusHG
Copy link
Contributor

@ArtikusHG ArtikusHG commented Nov 19, 2023

This PR makes the build action fail when just --fmt --check fails (#152).

Note: currently, none of the justfiles we have here pass the formatting check. #156 must be merged first.

@castrojo
Copy link
Member

Thanks for both of these, this will catch my dumb mistakes!

I need someone more technical to review @ublue-os/approver @ublue-os/member

@bobslept
Copy link
Contributor

Oh sweet, no more broken just ending up on the images! Happened a few times now, big quality improvement!

If this works well and is being approved we for sure need this (slightly modified) action in framework and bluefin repo too.

.github/workflows/build.yml Outdated Show resolved Hide resolved
@ArtikusHG ArtikusHG requested a review from KyleGospo November 19, 2023 20:37
@KyleGospo KyleGospo added this pull request to the merge queue Nov 19, 2023
@KyleGospo
Copy link
Member

Thank you for this!!

@ArtikusHG
Copy link
Contributor Author

@bobslept how many places do we need this in? If it's more than 2-3 it might make sense to not copy-paste the code but instead to make a separate repo with with this action, then we'll be able to just do something like:

- name: Check just syntax
  uses: ublue-os/check-just-syntax

Merged via the queue into ublue-os:main with commit ac88b3a Nov 19, 2023
2 checks passed
@fiftydinar
Copy link
Contributor

@ArtikusHG startingpoint would definitely need this

@ArtikusHG
Copy link
Contributor Author

ArtikusHG commented Nov 19, 2023

@fiftydinar it seems like we do need this in many places after all. I will make a separate repo with an action that we can easily include tomorrow. If someone could make a repo for it under the ublue org and give me write access that'd help a lot!

@castrojo
Copy link
Member

https://github.com/ublue-os/just-action/

All set, check your emails! Thanks ya'll!

@bobslept
Copy link
Contributor

@bobslept how many places do we need this in? If it's more than 2-3 it might make sense to not copy-paste the code but instead to make a separate repo with with this action, then we'll be able to just do something like:

- name: Check just syntax
  uses: ublue-os/check-just-syntax

@ArtikusHG sure is. Would be neat if we can specify the directory where the just files are. Because those differ from repo to repo.

@ArtikusHG
Copy link
Contributor Author

@bobslept yes I'm planning to do that, the final thing will look something like:

- name: Check just syntax
  uses: ublue-os/just-action
  with:
    directory: build/ublue-os-just

@bobslept
Copy link
Contributor

@bobslept yes I'm planning to do that, the final thing will look something like:

- name: Check just syntax
  uses: ublue-os/just-action
  with:
    directory: build/ublue-os-just

That is perfect. Thank you so much! 🥳

@ArtikusHG
Copy link
Contributor Author

Please take a look at ublue-os/just-action#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants